update VS project options cache when files are added/removed#1813
Merged
brettfo merged 1 commit intodotnet:masterfrom Nov 23, 2016
brettfo:add-file-crash
Merged
update VS project options cache when files are added/removed#1813brettfo merged 1 commit intodotnet:masterfrom brettfo:add-file-crash
brettfo merged 1 commit intodotnet:masterfrom
brettfo:add-file-crash
Conversation
Pilchie
approved these changes
Nov 23, 2016
Member
Pilchie
left a comment
There was a problem hiding this comment.
LGTM but I'd love another set of eyes on it.
Is there a way to add a test?
Member
There was a problem hiding this comment.
If these are source file paths, should we be using an OrdinalIgnoreCase comparer for the HashSets?
Member
Author
There was a problem hiding this comment.
Good catch, adding that now.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents VS from crashing when the cached project options don't know about a newly added file.
Fixes #1769.
This also fixes the crash when renaming a file that @cartermp mentioned.
@KevinRansom @Pilchie @cartermp @OmarTawfik @dsyme