Fix for missing IntelliSense after type constraint error#1568
Fix for missing IntelliSense after type constraint error#1568dsyme merged 4 commits intodotnet:masterfrom
Conversation
src/fsharp/TypeChecker.fs
Outdated
There was a problem hiding this comment.
I think this would be called UnifyTypesAndRecover. Also it feels like you should be calling errorRecovery in the error path rather than ignoring any exception completely.
There was a problem hiding this comment.
Done. I hadn't done any cleanup after my excitement in getting something working!
|
Looking at the errors, it appears that the following 3 tests are failing; some advice on how to proceed with regards to them would be appreciated.
|
|
@liboz Those errors appear harmless and you can just make test fixes (we'll review the test fixes in any case) The typecheck\sigs test is actually about 200 tests, and I believe it stops on first failure. So you might have to wade through a whole bunch of updates. If possible try to run these on your local machine. We should really break this out into 200 independently failing tests (if you get a chance to do that... :) ) |
c0fb770 to
536ddf6
Compare
|
I cleaned up the git history a bit and fixed all the relevant tests. I messed up my previous chart with regards to which was expected/new. Here's a new one for all the failing tests:
It seems the additional error might be because of the extra |
|
When running the tests without the |
|
@dsyme Is there any chance of this making F# 4.1? And/or getting into FCS so that Ionide can benefit? |
|
I'll close/reopen to trigger CI |
|
@dsyme The first time CI ran, there were unexpected errors such as on |
|
@dsyme, @KevinRansom Any chance this can be reviewed? |
|
This is a good change and will make a significant difference in intellisense accuracy for erroneous code. |
Rebasing @mpetruska's PR #848 to a more recent point. It attempts to fixes #629
