Hi @mpetruska, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

Currently the missing name resolutions are fixed:

A type constraint error occurs when the type checker tries to unify types unit and 'a list, after which type inference is not run to specialize List.map, hence the type of the function parameter (abcd) is left as 'a.

Further work is needed to try to infer the types for IntelliSense.

Interesting fix. I believe I've seen other manifestations of this problem. Does the change pass all the IDE nunit tests? If you could add a new IDE unit test that would be great.

Unfortunately I'm having some trouble with the IDE unit tests.

Running the IDE tests (RunTests.cmd debug ideunit) without the changes gives the following results:

Tests run: 4146, Passed: 3289, Errors: 154, Failures: 703, Inconclusive: 0

With my changes the result is:

Tests run: 4149, Passed: 3292, Errors: 154, Failures: 703, Inconclusive: 0

In my opinion the type inference problem (see above) can be solved, will continue to work on it.

@mpetruska what are the ideunit failures?

@enricosada
Here is the log of the test run without the changes: IDEUnit_Output_base.log.txt
Here is the one that contain my changes: IDEUnit_Output_withchanges.log.txt

I checked a couple of failures manually (only IntelliSense ones), they seemed to work correctly in Visual Studio 2015. I think there's some configuration issue on my box, I'm using Windows 8.1 and the Community edition of VS 2015 (Version 14.0.24720.00 Update 1, .Net 4.6).

@mpetruska Hi, how is this PR progressing? should I close it, or is it ready for review?

Hi @KevinRansom, sorry for the late reply, unfortunately I could not find time to update this one. Also I think the code is so out-of-date, that it's better to close it.

I will keep it around, and maybe someone will have the time to pick it up.

and thank you for taking the time to get this started.

Kevin

Closing