New code fix: change equals in record field definition to colon#15456
Merged
psfinaki merged 18 commits intodotnet:mainfrom Aug 3, 2023
Merged
New code fix: change equals in record field definition to colon#15456psfinaki merged 18 commits intodotnet:mainfrom
psfinaki merged 18 commits intodotnet:mainfrom
Conversation
T-Gro
reviewed
Jun 21, 2023
vsintegration/src/FSharp.Editor/CodeFixes/ChangeEqualsInFieldTypeToColon.fs
Outdated
Show resolved
Hide resolved
T-Gro
reviewed
Jun 21, 2023
T-Gro
reviewed
Jun 21, 2023
vsintegration/tests/FSharp.Editor.Tests/CodeFixes/ChangeEqualsInFieldTypeToColonTests.fs
Outdated
Show resolved
Hide resolved
T-Gro
requested changes
Jun 21, 2023
Member
T-Gro
left a comment
There was a problem hiding this comment.
See comment at codefix impl - the allocation path should be zero in case the diagnostic FS0010 is for something else.
Error FS0010 comes very often when typing for all sorts of reasons.
Contributor
|
Can we use the same code fix to also make the fix in the opposite direction? When |
Contributor
Author
I'd keep it for a followup and maybe for a separate code fix. It would require different ParseTree logic. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
T-Gro
reviewed
Jun 21, 2023
vsintegration/src/FSharp.Editor/CodeFixes/ChangeEqualsInFieldTypeToColon.fs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
vsintegration/src/FSharp.Editor/CodeFixes/ChangeEqualsInFieldTypeToColon.fs
Outdated
Show resolved
Hide resolved
T-Gro
approved these changes
Aug 2, 2023
Contributor
Author
|
/azp run |
|
No commit pushedDate could be found for PR 15456 in repo dotnet/fsharp |
0101
approved these changes
Aug 3, 2023
vzarytovskii
added a commit
that referenced
this pull request
Aug 4, 2023
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Edgar Gonzalez <edgar.gonzalez@fundourselves.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Petr <psfinaki@users.noreply.github.com> Co-authored-by: Vlad Zarytovskii <vzaritovsky@hotmail.com> fix: change equals in record field definition to colon (#15456)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #15421
We started this code fix at the recent Amplifying F# session.
Change
to
Inspired by FsAutoComplete. :)