First take on the F# telemetry #14889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
ryzngard
approved these changes
Mar 13, 2023
Contributor
ryzngard
left a comment
There was a problem hiding this comment.
I'm not great at reading f#, but this looks like what I would expect
vzarytovskii
approved these changes
Mar 13, 2023
0101
reviewed
Mar 14, 2023
vsintegration/src/FSharp.Editor/LanguageService/WorkspaceExtensions.fs
Outdated
Show resolved
Hide resolved
0101
approved these changes
Mar 14, 2023
vzarytovskii
pushed a commit
that referenced
this pull request
Mar 14, 2023
* Cache parsing results in incremental build (#14852) * First take on the F# telemetry (#14889) * Array.Parallel - search functions (tryFindIndex,tryFind,tryPick) (#14827) * Searching functions for Array.Parallel added * with [<Experimental("Experimental library feature, requires '--langversion:preview'")>] annotation to give us space to change/remove this API in the future if needed * Add `GraphNode.FromResult` (#14894) * Add GraphNode.FromResult * fantomas * Fix missing reference (#14892) * Fix missing reference * undo whitespace change --------- Co-authored-by: Jakub Majocha <1760221+majocha@users.noreply.github.com> Co-authored-by: Petr <psfinaki@users.noreply.github.com> Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: Petr Pokorny <petrpokorny@microsoft.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first shot on the F#-specific telemetry in the VS.
One of the things we are interested in is the usage of our preview/experimental features: #14872
So here we achieve that by sending respective events. Here is how things look like in the VS monitor:
This is inspired by Razor's TelemetryReporter.
As of now, there is no proper thought behind the structure of events or any event design for that matter - we are just getting our hands dirty here.