Skip to content

Suggest types - fixes #1446#1449

Merged
KevinRansom merged 1 commit intodotnet:masterfrom
forki:typesuggestion
Aug 23, 2016
Merged

Suggest types - fixes #1446#1449
KevinRansom merged 1 commit intodotnet:masterfrom
forki:typesuggestion

Conversation

@forki
Copy link
Contributor

@forki forki commented Aug 16, 2016

image

@forki forki mentioned this pull request Aug 16, 2016
Closed
@forki forki force-pushed the typesuggestion branch 4 times, most recently from 45f1d7d to 69a2545 Compare August 16, 2016 18:21
@KevinRansom
Copy link
Contributor

KevinRansom commented Aug 16, 2016

@forki
Test errors:

+++ Warnings (SuggestTypesInModule.fs) +++
Microsoft (R) F# Compiler version 4.1
Copyright (c) Microsoft Corporation. All Rights Reserved.
(6,36): error FS0039: The type 'Lst' is not defined in 'System.Collections.Generic'.

Maybe you want one of the following:

   List

   IList

   Comparer

   Dictionary

   IComparer

*** The following necessary lines were never matched:
*** error FS0039:.+The value, constructor, namespace or type 'Lst' is not defined


*** The following necessary lines were incorrectly matched:

Unexpected Compiler Output 
FAIL
``

@forki
Copy link
Contributor Author

forki commented Aug 16, 2016

Yep I'm on it

@forki forki force-pushed the typesuggestion branch 4 times, most recently from 90c033c to ed6f731 Compare August 17, 2016 08:05
@forki
Copy link
Contributor Author

forki commented Aug 17, 2016

@enricosada @KevinRansom this is a bit tricky. the build doesn't come to neg2 test on my machine because other stuff is failing.

So I can't really check what's wrong.

KevinRansom
KevinRansom reviewed Aug 20, 2016
View reviewed changes
src/fsharp/NameResolution.fs Outdated
Copy link
Contributor

@KevinRansom KevinRansom Aug 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forki
The AtMostResult indicates that this error can produce a message more than once:

Indeed the error messages produced in the failing neg2 testcase looks like this:


neg2.fsx(3,59,3,66): typecheck error FS3033: The type provider 'Provider.GoodProviderForNegativeTypeTests1' reported an error: Kaboom

neg2.fsx(3,59,3,66): typecheck error FS3033: The type provider 'Provider.GoodProviderForNegativeTypeTests1' reported an error: Kaboom

neg2.fsx(3,59,3,66): typecheck error FS0039: The value, constructor, namespace or type 'TheHype' is not defined

Maybe you want one of the following:

   TheType

Copy link
Contributor Author

@forki forki Aug 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AtMostOneResult was moved to line 2025. but thanks for the test report. I will try to fix that.

@forki
Copy link
Contributor Author

forki commented Aug 22, 2016

ok this is ready for review

@KevinRansom
Copy link
Contributor

KevinRansom commented Aug 23, 2016

@forki
Okay looks good to me. Pulling ...

Thanks for taking care of this :

The text "Maybe you want pne of the following" seems hokey to me. Could we consider changing it to something more like "Consider one of the following:"

Kevin

@KevinRansom KevinRansom merged commit dc4e5e5 into dotnet:master Aug 23, 2016
@forki
Copy link
Contributor Author

forki commented Aug 23, 2016

Yes we should change that. I'm not native speaker so I hope others find a
good solution

Am 23.08.2016 10:12 nachm. schrieb "Kevin Ransom (msft)" <
notifications@github.com>:

Merged #1449 #1449.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1449 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADgNAtYqlUneurmEZt2fxwQv4m2htuuks5qi1Q3gaJpZM4JlY51
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@forki @KevinRansom @msftclas