Create fcs solution #10137
Merged
Create fcs solution #10137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@KevinRansom Yes, it seems to do exactly what we wanted. Thank you! |
Contributor
Author
|
@auduchinok, Yes, I can rename it. |
cartermp
approved these changes
Sep 17, 2020
vzarytovskii
approved these changes
Sep 17, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Create fcs solution * Rename Fcs.sln to FSharp.Compiler.Service.sln * Update Directory.Build.props * Update Directory.Build.props Co-authored-by: KevinRansom <codecutter@Hotmail>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an fcs solution to the repo. The fcs solution, includes the FSharp.CompilerService and FSharp.CompilerService tests project.
It's primary purpose is for developers who want to use the compiler service with a nuget package rather than the FSharp.Core project.
So, if you open fcs.sln in visual studio, then you will use FSharp.Core from a package, if you load FSharp.sln or VisualFSharp.sln then we will use fsharp.core as a project.
I removed FSharp.Compiler.Service.slnf, because the fcs seems to cover the same scenario. Although that would end up using FSharp.Core from a project.
/cc @auduchinok --- would this help with your fcs scenarios?
Kevin