[release/10.0] Fix parameter counting when type mapping differs. #37333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0bcf09 to
6c6562c
Compare
SamMonoRT
approved these changes
Dec 10, 2025
roji
approved these changes
Dec 10, 2025
test/EFCore.Specification.Tests/Query/PrimitiveCollectionsQueryTestBase.cs
Show resolved
Hide resolved
Contributor
Author
|
cc @artl93 |
artl93
approved these changes
Dec 10, 2025
Member
artl93
left a comment
There was a problem hiding this comment.
Good catch. Customer reported. Completes fix found before shipping. Approved.
Contributor
Author
|
Approved via email. |
This was referenced Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #37185 and #37320.
Description
This change fixes an edge case in the previously approved fix for #37320. While the existing logic is generally correct, it did not account for a rare scenario where the type mappings for a column differ. This update addresses that gap.
Customer impact
Query fails to execute.
How found
Customer reported on #37320.
Regression
N/A.
Testing
Tests added.
Risk
Low. Quirk already exists for #37320.