[release/10.0] Fallback to OPENJSON with many parameters #37320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf09894 to
2f4f408
Compare
2f4f408 to
31df649
Compare
roji
approved these changes
Dec 8, 2025
SamMonoRT
approved these changes
Dec 8, 2025
Contributor
Author
|
cc @artl93 |
artl93
approved these changes
Dec 8, 2025
Member
artl93
left a comment
There was a problem hiding this comment.
Customer reported regression. Approved.
Contributor
Author
|
Approved via email. |
This was referenced Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #37234.
Fixes #37185.
Description
EF 10 changed the default translation for parameterized collections from single parameter and JSON function to multiple parameters. To not go over the limit of parameters (2100) on SQL Server we introduced logic that counts parameters. Unfortunately this logic was not taking into account total number of parameters, but only local sums.
Customer impact
Query fails to execute because of >2100 parameters in query.
How found
Customer reported on 10.0.
Regression
Yes.
Testing
Tests added.
Risk
Low. Quirk added.