Fixes around IncludeExpression for ExecuteUpdate/Delete#30571
Merged
roji merged 2 commits intodotnet:mainfrom Mar 25, 2023
Merged
Fixes around IncludeExpression for ExecuteUpdate/Delete#30571roji merged 2 commits intodotnet:mainfrom
roji merged 2 commits intodotnet:mainfrom
Conversation
8153f74 to
945be53
Compare
maumar
previously approved these changes
Mar 24, 2023
Member
Author
|
@maumar I pushed another commit here in order to also fix #30572, which is related; basically is to prune all IncludeExpressions before ExecuteUpdate/Delete, since they have no meaning in that context (nothing is coming back from the database) and they interfere with translation. This works well for SQL Server, but the new test Delete_entity_with_auto_include fails for SQLite; since SQLite doesn't support JOINs directly, we use a different path and transform to subquery with entity equality (code). There's a weird exception happening in this path, which looks like a malformed ProjectionBindingExpression (see stack trace below). I don't think I introduced this bug here, but can you please tell a look and tell me what you think? Exception stack trace |
Contributor
|
the new change looks good, I will try to dig into the underlying projection binding issue, but that's orthogonal. |
maumar
approved these changes
Mar 24, 2023
roji
added a commit
to roji/efcore
that referenced
this pull request
Mar 25, 2023
* Fully prune IncludeExpression before ExecuteUpdate, not just for the property lambda * Prune also non-owned Includes Fixes dotnet#30572 Fixes dotnet#30528 (cherry picked from commit 4c6f854)
wtgodbe
pushed a commit
that referenced
this pull request
Apr 4, 2023
roji
added a commit
to roji/efcore
that referenced
this pull request
Nov 17, 2023
* Fully prune IncludeExpression before ExecuteUpdate, not just for the property lambda * Prune also non-owned Includes Fixes dotnet#30572 Fixes dotnet#30528 (cherry picked from commit 4c6f854)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30528
Fixes #30572