Ensure warnings configured to throw really do throw with the SQL Server provider#29086
Merged
ajcvickers merged 1 commit intorelease/7.0from Sep 14, 2022
Merged
Ensure warnings configured to throw really do throw with the SQL Server provider#29086ajcvickers merged 1 commit intorelease/7.0from
ajcvickers merged 1 commit intorelease/7.0from
Conversation
…er provider Fixes #29069
Contributor
Author
Member
|
Oh wow, yeah... I had to stare at that for a couple minutes before I saw it... In fact I wouldn't trust myself not to refactor that back :) Good thing there are tests. |
roji
added a commit
to npgsql/efcore.pg
that referenced
this pull request
Sep 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this is a breaking change because this bug was preventing exceptions being thrown when they should have been.
Fixes #29069