Translate DateTimeOffset.ToUnixTime[Seconds|Milliseconds] #28978
Merged
bricelam merged 2 commits intodotnet:mainfrom Mar 30, 2023
Merged
Translate DateTimeOffset.ToUnixTime[Seconds|Milliseconds] #28978bricelam merged 2 commits intodotnet:mainfrom
bricelam merged 2 commits intodotnet:mainfrom
Conversation
roji
previously requested changes
Sep 4, 2022
Member
roji
left a comment
There was a problem hiding this comment.
See also SQLite test failures, you probably need to implement those tests and assert on them failing (unless there's a translation on SQLite as well).
src/EFCore.SqlServer/Query/Internal/SqlServerDateTimeMethodTranslator.cs
Outdated
Show resolved
Hide resolved
src/EFCore.SqlServer/Query/Internal/SqlServerDateTimeMethodTranslator.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Marked as |
smitpatel
reviewed
Sep 7, 2022
src/EFCore.SqlServer/Query/Internal/SqlServerDateTimeMethodTranslator.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Sep 7, 2022
test/EFCore.Specification.Tests/Query/NorthwindFunctionsQueryTestBase.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Sep 7, 2022
test/EFCore.Sqlite.FunctionalTests/Query/NorthwindFunctionsQuerySqliteTest.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Cosmos has |
Member
|
Converting to draft for now as we're not merging this for 7.0. |
bricelam
reviewed
Sep 7, 2022
test/EFCore.Sqlite.FunctionalTests/Query/NorthwindFunctionsQuerySqliteTest.cs
Outdated
Show resolved
Hide resolved
test/EFCore.Sqlite.FunctionalTests/Query/NorthwindFunctionsQuerySqliteTest.cs
Outdated
Show resolved
Hide resolved
Marusyk
commented
Sep 11, 2022
src/EFCore.Sqlite.Core/Query/Internal/SqliteDateTimeAddTranslator.cs
Outdated
Show resolved
Hide resolved
bricelam
reviewed
Sep 14, 2022
src/EFCore.Sqlite.Core/Query/Internal/SqliteDateTimeAddTranslator.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
Can I mark it "ready for review"? |
39d9a30 to
e1b3468
Compare
bricelam
added a commit
to Marusyk/efcore
that referenced
this pull request
Mar 20, 2023
Contributor
|
Rebased, removed SQLite translations, and propagated the type mapping from |
bricelam
approved these changes
Mar 20, 2023
bricelam
added a commit
to Marusyk/efcore
that referenced
this pull request
Mar 21, 2023
e1b3468 to
22d4490
Compare
22d4490 to
72ab932
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added translation for
DateTimeOffset.ToUnixTime[Seconds|Milliseconds]Fixes #28925
Could anyone help me improve the tests?
Thank you in advance