Scaffolding: Refactor some code#28358
Merged
bricelam merged 1 commit intodotnet:mainfrom Jul 11, 2022
Merged
Conversation
AndriySvyryd
reviewed
Jul 2, 2022
src/EFCore.Design/Extensions/Internal/DatabaseColumnExtensions.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
reviewed
Jul 2, 2022
src/EFCore.Design/Extensions/Internal/InternalScaffoldingModelExtensions.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
reviewed
Jul 2, 2022
AndriySvyryd
reviewed
Jul 2, 2022
AndriySvyryd
reviewed
Jul 2, 2022
AndriySvyryd
reviewed
Jul 2, 2022
src/EFCore.Design/Scaffolding/Internal/TextTemplatingModelGenerator.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
reviewed
Jul 2, 2022
AndriySvyryd
reviewed
Jul 2, 2022
AndriySvyryd
reviewed
Jul 2, 2022
AndriySvyryd
reviewed
Jul 2, 2022
test/EFCore.Design.Tests/Scaffolding/Internal/ScaffoldingMetadataExtensionsTest.cs
Show resolved
Hide resolved
AndriySvyryd
reviewed
Jul 2, 2022
test/EFCore.Design.Tests/Scaffolding/Internal/TextTemplatingModelGeneratorTest.cs
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Jul 8, 2022
smitpatel
approved these changes
Jul 9, 2022
Part of dotnet#4038, part of dotnet#27588, resolves dotnet#8434, resolves dotnet#21882, part of dotnet#26349
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My templates branch is getting a bit big, so I'm breaking these changes off into their own PR.
Part of #4038, part of #27588, resolves #8434, resolves #21882, part of #26349