Skip to content

Fix parameter type mapping for Sqlite#27291

Merged
bricelam merged 3 commits intodotnet:mainfrom
Marusyk:rmrusyk/27213
May 31, 2022
Merged

Fix parameter type mapping for Sqlite#27291
bricelam merged 3 commits intodotnet:mainfrom
Marusyk:rmrusyk/27213

Conversation

@Marusyk
Copy link
Member

@Marusyk Marusyk commented Jan 26, 2022

Small fix of the parameter type mapping

Fixes #27213

@Saibamen
Copy link

Unit tests needed?

bricelam added a commit to Marusyk/efcore that referenced this pull request Feb 4, 2022
@bricelam
Copy link
Contributor

bricelam commented Feb 4, 2022

Rebased and added some tests.

@dotnet/efteam Can I get a second review since I changed additional product code?

@bricelam bricelam requested a review from a team February 4, 2022 20:55
@daniel-smith
Copy link

daniel-smith commented May 28, 2022

It looks like this has been approved for 3 months. Any ideas on when this will be merged? Thanks.

@bricelam
Copy link
Contributor

I mean, I have til November, don't I? 😏

@bricelam bricelam merged commit d1a38d8 into dotnet:main May 31, 2022
@bricelam
Copy link
Contributor

Thanks for you contribution! (lol, and patience)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct SqliteType inference from string, DateOnly, TimeOnly

6 participants