Fix HierarchyId to support numbers outside Int32 range#2359
Merged
AndriySvyryd merged 4 commits intomainfrom Mar 5, 2026
Merged
Fix HierarchyId to support numbers outside Int32 range#2359AndriySvyryd merged 4 commits intomainfrom
AndriySvyryd merged 4 commits intomainfrom
Conversation
Change internal storage from int to long (Int64) to support hierarchy IDs with numbers exceeding Int32.MaxValue, such as SQL Server file table path_locator values like /239196746533516.54209197962074.2160059995/. Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix parsing issue for hierarchy IDs with numbers outside Int32 range
Fix HierarchyId to support numbers outside Int32 range
Mar 5, 2026
There was a problem hiding this comment.
Pull request overview
Fixes HierarchyId.Parse rejecting valid hierarchy IDs containing numeric segments larger than Int32.MaxValue (e.g. SQL Server FileTable path_locator defaults) by widening the internal node representation and parsing logic to long.
Changes:
- Widened
HierarchyIdinternal storage and comparison helpers frominttolong. - Updated parsing to use
long.TryParsefor node segments. - Added unit tests covering parsing and comparison of large numeric segments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/UnitTests/Hierarchy/HierarchyIdUnitTests.cs | Adds regression tests for large-number parsing and comparisons. |
| src/EntityFramework/Hierarchy/HierarchyId.cs | Switches node storage/parsing/comparison to long to support large hierarchy segments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
AndriySvyryd
approved these changes
Mar 5, 2026
…CompareLongArrays Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
roji
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_nodesfield fromint[][]tolong[][]in HierarchyId.csint.TryParsetolong.TryParsein constructorLongArrayToStringhelper to acceptIEnumerable<long>(renamed fromIntArrayToStirng)CompareLongArrayshelper to uselong[]andlonglocals (renamed fromCompareIntArrays)new[] { 1 }inGetDescendanttonew[] { 1L }for long compatibilityIntArrayToStirng→LongArrayToString,CompareIntArrays→CompareLongArraysOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.