Update samples to .NET 8 by richlander · Pull Request #4742 · dotnet/dotnet-docker

richlander · 2023-07-11T22:10:38Z

The samples need to be updated to .NET 8. We intend to publish these changes with .NET 8 RC1.

Intended changes:

Switch to port 8080
Switch to non-root
Produce Windows-specific tags
Push Chiseled images
Push composite images, for ASP.NET Core
Adopt new SDK changes (like -a)
Adopt new pattern for multi-platform images (like --platform $BUILDPLATFORM)
Remove most/all msbuild properties from Dockerfiles. Properties -- like PublishTrimmed -- should be in project files so that developers get good feedback from analyzers. Our previous use of msbuild properties in Dockerfiles is an anti-pattern.
Removed the slim versions because they rely on project properties in Dockerfiles and due to MVC apps no longer work with PublishTrimmed aspnetcore#49360.
I added new "releases*" samples. They produce this output: https://gist.github.com/richlander/6c6eefaf47e7d65c42822d8c00c2620a

TODO:

Document and test docker buildx build

Reported two bugs while doing this work:

lbussell · 2023-07-12T17:46:49Z

Publishing these samples will be blocked on dotnet/docker-tools#1159

richlander · 2023-07-12T17:51:49Z

Same thing for #4743

manifest.samples.json

Co-authored-by: Justin Anderson <jander-msft@users.noreply.github.com>

lbussell · 2023-07-19T00:25:02Z

@richlander, I'll be trying a few things here to get these samples building.

samples/aspnetapp/aspnetapp/Program.cs

jetersen · 2023-09-08T15:38:50Z

I ran into this issue trying to compile with the nightly sdk aot rc mcr.microsoft.com/dotnet/nightly/sdk:8.0-jammy-aot@sha256:c477e92a600d5a8aa052c93503a6d65c3

0.560 MSBuild version 17.7.0+5785ed5c2 for .NET
0.959   Determining projects to restore...
3.030 /tmp/project/project.csproj : warning NU1603: BitwardenDirectorySync depends on Microsoft.NET.ILLink.Tasks (>= 8.0.0-rc.1.23414.4) but Microsoft.NET.ILLink.Tasks 8.0.0-rc.1.23414.4 was not found. An approximate best match of Microsoft.NET.ILLink.Tasks 8.0.100-1.23067.1 was resolved.
3.036 /tmp/project/project.csproj : error NU1102: Unable to find package Microsoft.DotNet.ILCompiler with version (>= 8.0.0-rc.1.23414.4)
3.036 /tmp/project/project.csproj : error NU1102:   - Found 25 version(s) in nuget.org [ Nearest version: 8.0.0-preview.7.23375.6 ]
3.037 /tmp/project/project.csproj : error NU1102: Unable to find package Microsoft.NETCore.App.Runtime.linux-x64 with version (= 8.0.0-rc.1.23414.4)
3.037 /tmp/project/project.csproj : error NU1102:   - Found 130 version(s) in nuget.org [ Nearest version: 8.0.0-preview.7.23375.6 ]
3.037 /tmp/project/project.csproj : error NU1102: Unable to find package runtime.linux-x64.Microsoft.DotNet.ILCompiler with version (= 8.0.0-rc.1.23414.4)
3.037 /tmp/project/project.csproj : error NU1102:   - Found 25 version(s) in nuget.org [ Nearest version: 8.0.0-preview.7.23375.6 ]
3.037 /tmp/project/project.csproj : error NU1102: Unable to find package Microsoft.AspNetCore.App.Runtime.linux-x64 with version (= 8.0.0-rc.1.23414.10)
3.037 /tmp/project/project.csproj : error NU1102:   - Found 130 version(s) in nuget.org [ Nearest version: 8.0.0-preview.7.23375.9 ]
3.171   Failed to restore /tmp/project/project.csproj (in 1.53 sec).

mthalman · 2023-09-08T15:11:57Z

eng/common/templates/steps/init-docker-linux.yml

  - script: >
      echo "##vso[task.setvariable variable=runImageBuilderCmd]
-      docker run --rm
+      \$env:DOCKER_BUILDKIT=1; docker run --rm


This shouldn't be needed anymore.

mthalman · 2023-09-08T15:14:24Z

eng/common/templates/variables/docker-images.yml

@@ -1,5 +1,5 @@
 variables:
-  imageNames.imageBuilderName: mcr.microsoft.com/dotnet-buildtools/image-builder:2230260
+  imageNames.imageBuilderName: mcr.microsoft.com/dotnet-buildtools/image-builder:2233114


Suggested change

imageNames.imageBuilderName: mcr.microsoft.com/dotnet-buildtools/image-builder:2233114

imageNames.imageBuilderName: mcr.microsoft.com/dotnet-buildtools/image-builder:2240150

mthalman · 2023-09-08T15:18:05Z

samples/aspnetapp/Dockerfile

 # Learn about building .NET container images:
 # https://github.com/dotnet/dotnet-docker/blob/main/samples/README.md
-FROM mcr.microsoft.com/dotnet/sdk:7.0 AS build
+FROM --platform=$BUILDPLATFORM mcr.microsoft.com/dotnet/sdk:8.0-preview AS build


All 8.0-preview tags in this PR will need to be updated to just 8.0.

mthalman · 2023-09-08T15:34:55Z

samples/releasesapi-aot/Dockerfile.debian-cross-x64-arm64

+
+# copy and publish app and libraries
+COPY . .
+RUN dotnet publish -a $TARGETARCH --self-contained --no-restore -o /app releasesapi.csproj


If we're going to use --ucr instead of --use-current-runtime then we should use --sc instead of --self-contained. Applies to other Dockerfiles too.

mthalman · 2023-09-08T15:53:33Z

samples/dotnetapp/README.md

+- [Alpine with ICU installed](Dockerfile.alpine-icu)
 - [Debian](Dockerfile.debian)
 - [Ubuntu](Dockerfile.ubuntu)
 - [Ubuntu Chiseled](Dockerfile.chiseled)


Should we also have Dockerfile.chiseled-icu that uses the extra image?

Good idea. Let's have a conversation on how to handle ICU with these samples. It's a question of whether we want to favor a little extra ceremony or push people to SCD (which the extra images would required). I'm open to either, but its a policy topic for us to discuss.

mthalman · 2023-09-08T16:23:13Z

samples/releasesapi-aot/ReportGenerator.cs

+        {
+            // Only show releases in support or < 1 year EOL
+            if (DateOnly.TryParse(releaseSummary.EolDate, out DateOnly eolDate)
+             && DateOnly.FromDateTime(DateTime.UtcNow.AddYears(-1)).DayNumber > eolDate.DayNumber)


Suggested change

&& DateOnly.FromDateTime(DateTime.UtcNow.AddYears(-1)).DayNumber > eolDate.DayNumber)

&& DateOnly.FromDateTime(DateTime.UtcNow.AddYears(-1)).DayNumber > eolDate.DayNumber)

mthalman · 2023-09-08T16:26:38Z

samples/releasesapi-aot/ReportGenerator.cs

+    {
+        HttpClient httpClient = new();
+        var loadError = "Failed to load release information.";
+        var releases = await httpClient.GetFromJsonAsync<ReleaseIndex>(ReleaseValues.RELEASE_INDEX_URL, ReleaseJsonSerializerContext.Default.ReleaseIndex) ?? throw new Exception(loadError);


Is there a reason that the library from https://www.nuget.org/packages/Microsoft.Deployment.DotNet.Releases isn't used instead?

I wrote this sample for another reason, to demonstrate System.Text.Json (for a blog post). We can certainly update this code to use that library.

mthalman · 2023-09-08T16:28:01Z

samples/releasesapi-aot/releasesapi.sln

Consider deleting this. There's only one project here and this doesn't add any value.

It's devkit. It generates these all the time so I decided to check it in.

mthalman · 2023-09-08T16:29:56Z

tests/Microsoft.DotNet.Docker.Tests/SampleImageData.cs

+            // if (os == Tests.OS.Alpine)
+            // {
+            //     os += "-slim";
+            // }


mthalman · 2023-09-08T16:31:44Z

tests/Microsoft.DotNet.Docker.Tests/TestData.cs

+            // new SampleImageData { OS = OS.Alpine,       Arch = Arch.Amd64, DockerfileSuffix = "alpine-slim", IsPublished = true },
+            // new SampleImageData { OS = OS.Alpine,       Arch = Arch.Arm,   DockerfileSuffix = "alpine-slim", IsPublished = true },
+            // new SampleImageData { OS = OS.Alpine,       Arch = Arch.Arm64, DockerfileSuffix = "alpine-slim", IsPublished = true },


Doesn't this need to be replaced with the jammy-chiseled Dockerfiles?

mthalman · 2023-09-08T16:38:25Z

I can into this issue trying to compile with the nightly sdk aot rc mcr.microsoft.com/dotnet/nightly/sdk:8.0-jammy-aot@sha256:c477e92a600d5a8aa052c93503a6d65c3

0.560 MSBuild version 17.7.0+5785ed5c2 for .NET
0.959   Determining projects to restore...
3.030 /tmp/project/project.csproj : warning NU1603: BitwardenDirectorySync depends on Microsoft.NET.ILLink.Tasks (>= 8.0.0-rc.1.23414.4) but Microsoft.NET.ILLink.Tasks 8.0.0-rc.1.23414.4 was not found. An approximate best match of Microsoft.NET.ILLink.Tasks 8.0.100-1.23067.1 was resolved.
3.036 /tmp/project/project.csproj : error NU1102: Unable to find package Microsoft.DotNet.ILCompiler with version (>= 8.0.0-rc.1.23414.4)
3.036 /tmp/project/project.csproj : error NU1102:   - Found 25 version(s) in nuget.org [ Nearest version: 8.0.0-preview.7.23375.6 ]
3.037 /tmp/project/project.csproj : error NU1102: Unable to find package Microsoft.NETCore.App.Runtime.linux-x64 with version (= 8.0.0-rc.1.23414.4)
3.037 /tmp/project/project.csproj : error NU1102:   - Found 130 version(s) in nuget.org [ Nearest version: 8.0.0-preview.7.23375.6 ]
3.037 /tmp/project/project.csproj : error NU1102: Unable to find package runtime.linux-x64.Microsoft.DotNet.ILCompiler with version (= 8.0.0-rc.1.23414.4)
3.037 /tmp/project/project.csproj : error NU1102:   - Found 25 version(s) in nuget.org [ Nearest version: 8.0.0-preview.7.23375.6 ]
3.037 /tmp/project/project.csproj : error NU1102: Unable to find package Microsoft.AspNetCore.App.Runtime.linux-x64 with version (= 8.0.0-rc.1.23414.10)
3.037 /tmp/project/project.csproj : error NU1102:   - Found 130 version(s) in nuget.org [ Nearest version: 8.0.0-preview.7.23375.9 ]
3.171   Failed to restore /tmp/project/project.csproj (in 1.53 sec).

The nightly images contain non-official builds of .NET, currently on 8.0 RC1. When consuming them, you'll need to setup your NuGet config to target the feed which contains these packages:

dotnet-docker/tests/Microsoft.DotNet.Docker.Tests/TestAppArtifacts/NuGet.config.nightly

Line 7 in f270639

    
           <add key="dotnet8" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json" />

Co-authored-by: Matt Thalman <mthalman@microsoft.com>

lbussell · 2023-09-13T18:58:38Z

Looks like there is a NanoServer issue with virtualization/Docker...

richlander · 2023-09-13T22:41:29Z

What should we do about the Nanoserver issue? I assume that doesn't block merging then?

lbussell · 2023-09-13T23:39:46Z

You'll notice the build was only failing due to the ComplexAppTest on NanoServer legs.. A few notes on that:

We don't publish complexapp (it's not in manifest.samples.json)
complexapp did not (until I just updated it) support Windows on .NET 8 due to Switch multi-platform tags to Linux only #4492
complexapp is only built in the VerifyComplexAppSample test. This means it only runs on one OS on all legs.. kind of weird. I feel like it should run across all of the images. I defaulted it to nanoserver-1809. We should open an issue to make this test a [Theory]

Hopefully the changes make it work, and the strange error message was just a side effect of things being different between Docker Desktop/the build agents with Docker CE.

…test" This reverts commit b44093a.

richlander · 2023-09-14T04:15:32Z

tests/Microsoft.DotNet.Docker.Tests/SampleImageTests.cs

        [Fact]
        public void VerifyComplexAppSample()
        {
+            // complexapp sample doesn't currently support building on Windows.


I think this is wrong. The app works fine on Windows, right?

The app works fine but the Dockerfile is multi-platform so it won't work on Windows. I can amend the comment.

Let's merge first and then deal with that later.

Filed #4873 for this.

Co-authored-by: Justin Anderson <jander-msft@users.noreply.github.com> Co-authored-by: Logan Bussell <loganbussell@microsoft.com> Co-authored-by: Damian Edwards <damian@damianedwards.com> Co-authored-by: Matt Thalman <mthalman@microsoft.com>

Update dotnetapp sample to .NET 8

3c97828

ghost added area-samples untriaged labels Jul 11, 2023

richlander changed the title ~~Update sample to .NET 8~~ Update samples to .NET 8 Jul 11, 2023

richlander mentioned this pull request Jul 11, 2023

Consider creating a docker buildx build test #4743

Open

richlander added 3 commits July 11, 2023 16:33

Update ASP.NET sample

a0a73f8

Update

71e0059

Update Windows samples

fdd1d3b

lbussell mentioned this pull request Jul 12, 2023

Enable use of BuildKit in CI dotnet/docker-tools#1159

Closed

richlander added 2 commits July 12, 2023 11:08

Switch aspnetapp to chiseled

b8913bf

Add apiapp

6b713fc

jander-msft reviewed Jul 12, 2023

View reviewed changes

manifest.samples.json Outdated Show resolved Hide resolved

richlander and others added 7 commits July 14, 2023 14:53

Add AOT and single file samples

3c97503

Update manifest.samples.json

bfd5ac7

Co-authored-by: Justin Anderson <jander-msft@users.noreply.github.com>

Update manifest

f855ea1

Add cross-target sample

0f5c025

Update cross-target Dockerfile

6104c2e

Change image reference

764f30d

Add build-essential package

b538842

richlander mentioned this pull request Jul 17, 2023

.NET 8 samples size report #4756

Closed

richlander added 3 commits July 16, 2023 19:17

Add more SF variants

23cb595

Update README

55faf5c

Update READMEs

37ffee7

lbussell added 3 commits July 18, 2023 17:25

Enable buildkit on agent

e7e9ee6

Merge branch 'main' into dotnet-8-samples

445fe0f

Escape powershell variable definition in bash

609f130

DamianEdwards reviewed Jul 19, 2023

View reviewed changes

samples/aspnetapp/aspnetapp/Program.cs Show resolved Hide resolved

lbussell added 2 commits August 31, 2023 16:09

Update port env var

2625383

Use port 80 for ServiceMonitor.exe

15d0338

lbussell mentioned this pull request Sep 8, 2023

Add missing build-base package from Alpine AOT SDK #4858

Merged

Merge branch 'main' into dotnet-8-samples

d89c393

mthalman reviewed Sep 8, 2023

View reviewed changes

richlander and others added 8 commits September 11, 2023 10:34

Update to new images

6f59d02

Update samples/dotnetapp/README.md

d1c0835

Co-authored-by: Matt Thalman <mthalman@microsoft.com>

Update samples

4c058c1

Merge branch 'main' into dotnet-8-samples

b4538af

Merge remote-tracking branch 'upstream/main' into dotnet-8-samples

e891465

Update complex app to net8.0 TFM

d3682bd

Update globalapp to net8.0 TFM

6956662

Update more complexapp TFMs

5b7a5d3

Update READMEs

22b55d3

Use platform specific windows server version for complex app test

b44093a

lbussell added 2 commits September 13, 2023 19:00

Revert "Use platform specific windows server version for complex app …

1f5aa1f

…test" This reverts commit b44093a.

Disable test on Windows

fdc8ef9

richlander commented Sep 14, 2023

View reviewed changes

lbussell approved these changes Sep 14, 2023

View reviewed changes

richlander merged commit c09ce8b into dotnet:main Sep 14, 2023

richlander deleted the dotnet-8-samples branch September 14, 2023 16:07

lbussell mentioned this pull request Sep 18, 2023

Merge samples changes from main to nightly #4891

Merged

alanwest mentioned this pull request Dec 19, 2023

Simplify cartservice Dockerfile open-telemetry/opentelemetry-demo#1308

Merged

lbussell mentioned this pull request Sep 16, 2024

Update samples to .NET 9 #5882

Merged

12 tasks

	imageNames.imageBuilderName: mcr.microsoft.com/dotnet-buildtools/image-builder:2233114
	imageNames.imageBuilderName: mcr.microsoft.com/dotnet-buildtools/image-builder:2240150

	&& DateOnly.FromDateTime(DateTime.UtcNow.AddYears(-1)).DayNumber > eolDate.DayNumber)
	&& DateOnly.FromDateTime(DateTime.UtcNow.AddYears(-1)).DayNumber > eolDate.DayNumber)

Conversation

richlander commented Jul 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lbussell commented Jul 12, 2023

Uh oh!

richlander commented Jul 12, 2023

Uh oh!

Uh oh!

lbussell commented Jul 19, 2023

Uh oh!

Uh oh!

jetersen commented Sep 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mthalman commented Sep 8, 2023

Uh oh!

lbussell commented Sep 13, 2023

Uh oh!

richlander commented Sep 13, 2023

Uh oh!

lbussell commented Sep 13, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

richlander commented Jul 11, 2023 •

edited

Loading

jetersen commented Sep 8, 2023 •

edited

Loading