Merging changes from nightly repo into nightly branch#365
Merged
MichaelSimons merged 2 commits intonightlyfrom Feb 13, 2018
Merged
Merging changes from nightly repo into nightly branch#365MichaelSimons merged 2 commits intonightlyfrom
MichaelSimons merged 2 commits intonightlyfrom
Conversation
ravimeda
reviewed
Feb 13, 2018
| { | ||
| string variantName = Enum.GetName(typeof(DotNetImageType), imageType).ToLowerInvariant().Replace('_', '-'); | ||
| string imageName = $"microsoft/dotnet:{imageVersion}-{variantName}"; | ||
| string imageName = $"microsoft/dotnet-nightly:{imageVersion}-{variantName}"; |
Member
There was a problem hiding this comment.
microsoft/dotnet-nightly this is easy to miss. Suggest having a GetDockerRepoName helper method.
Member
Author
There was a problem hiding this comment.
Agreed this is an existing issue covered by dotnet/docker-tools#21. Will fix later on.
MichaelSimons
added a commit
that referenced
this pull request
Feb 26, 2018
* Merging changes from nightly repo into nightly branch (#365) * Update nightly SDK to 2.1.300-preview1-008123 * Use ProductVersion from build info * Add support for specifying a custom repo-owner when building (#379) * Update nightly SDK to 2.1.300-preview1-008162 * Refactor pattern used to initial NuGet package cache (#382) * Refactor pattern used to initial NuGet package cache * Add tests to verify package cache exists in SDK images * Add Alpine SDK image (#376) * (update-dependencies) Use TLS1.2 when downloading from GitHub * Update nightly SDK to 2.1.300-preview1-008174 * Increase build timeout * 2.1 images (#385) * Update supported distros for 2.1 * Updating to latest SDK/Runtime versions * Add 2.1 build legs * Fix-up 'dotnet-nightly' references
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #dotnet/dotnet-docker-nightly#525