Skip to content

Conversation

@gewarren
Copy link
Contributor

This refresh includes the following key changes:

  • Exclude public APIs that implement the source generator
  • Add 3 assemblies that were previously omitted (System.Numerics.Vectors.dll, System.IO.Compression.Brotli.dll, System.Formats.Cbor.dll)

Replaces #7384 (we removed the System.Runtime.Experimental package for this pull request).


Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=264139&view=results
source_repo.branch:net6-ga
source_repo.url:https://apidrop.visualstudio.com/_git/binaries

 Build.Reason:Manual by Genevieve Warren
 Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=264139&view=results
 source_repo.branch:net6-ga
 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
@gewarren
Copy link
Contributor Author

Rerunning the CI job after removing the Microsoft.JSInterop.dll assembly, per #7286.

@opbld30

This comment has been minimized.

 Build.Reason:Manual by Genevieve Warren
 Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=264149&view=results
 source_repo.branch:net6-ga
 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
@opbld32

This comment has been minimized.

Copy link
Contributor Author

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we may want to rerun without the Cbor doc comments.

<AttributeName Language="F#">[&lt;System.Obsolete("This constructor is obsolete. Use the constructor which accepts arrays of EvidenceBase instead.")&gt;]</AttributeName>
</Attribute>
<Attribute FrameworkAlternate="netframework-4.0;netframework-4.5;netframework-4.5.1;netframework-4.5.2;netframework-4.6;netframework-4.6.1;netframework-4.6.2;netframework-4.7;netframework-4.7.1;netframework-4.7.2;netframework-4.8">
<Attribute FrameworkAlternate="dotnet-plat-ext-6.0;net-6.0;netframework-4.0;netframework-4.5;netframework-4.5.1;netframework-4.5.2;netframework-4.6;netframework-4.6.1;netframework-4.6.2;netframework-4.7;netframework-4.7.1;netframework-4.7.2;netframework-4.8">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the specific obsoletion messages got lost here for .NET Framework monikers.

@opbld34

This comment has been minimized.

@opbld32

This comment has been minimized.

@opbld34

This comment has been minimized.

 Build.Reason:Manual by Genevieve Warren
 Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=264548&view=results
 source_repo.branch:net6-ga
 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
@opbld30

This comment has been minimized.

@opbld30
Copy link

opbld30 commented Nov 17, 2021

Docs Build status updates of commit 44c4da4:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Security.Policy/Evidence.xml ⚠️Warning View Details
xml/FrameworksIndex/dotnet-plat-ext-6.0.xml ✅Succeeded
xml/FrameworksIndex/net-6.0.xml ✅Succeeded
xml/FrameworksIndex/windowsdesktop-6.0.xml ✅Succeeded
xml/Microsoft.Extensions.Configuration/IConfiguration.xml ✅Succeeded View
xml/Microsoft.JSInterop.Implementation/JSInProcessObjectReference.xml ✅Succeeded
xml/Microsoft.JSInterop.Implementation/JSObjectReference.xml ✅Succeeded
xml/Microsoft.JSInterop.Implementation/JSObjectReferenceJsonWorker.xml ✅Succeeded
xml/Microsoft.JSInterop.Implementation/JSStreamReference.xml ✅Succeeded
xml/Microsoft.JSInterop.Infrastructure/DotNetDispatcher.xml ✅Succeeded
xml/Microsoft.JSInterop.Infrastructure/DotNetInvocationInfo.xml ✅Succeeded
xml/Microsoft.JSInterop.Infrastructure/DotNetInvocationResult.xml ✅Succeeded
xml/Microsoft.JSInterop/DotNetObjectReference.xml ✅Succeeded
xml/Microsoft.JSInterop/DotNetObjectReference`1.xml ✅Succeeded
xml/Microsoft.JSInterop/DotNetStreamReference.xml ✅Succeeded
xml/Microsoft.JSInterop/IJSInProcessObjectReference.xml ✅Succeeded
xml/Microsoft.JSInterop/IJSInProcessRuntime.xml ✅Succeeded
xml/Microsoft.JSInterop/IJSObjectReference.xml ✅Succeeded
xml/Microsoft.JSInterop/IJSRuntime.xml ✅Succeeded
xml/Microsoft.JSInterop/IJSStreamReference.xml ✅Succeeded
xml/Microsoft.JSInterop/IJSUnmarshalledObjectReference.xml ✅Succeeded
xml/Microsoft.JSInterop/IJSUnmarshalledRuntime.xml ✅Succeeded
xml/Microsoft.JSInterop/JSCallResultType.xml ✅Succeeded
xml/Microsoft.JSInterop/JSDisconnectedException.xml ✅Succeeded
xml/Microsoft.JSInterop/JSException.xml ✅Succeeded
xml/Microsoft.JSInterop/JSInProcessObjectReferenceExtensions.xml ✅Succeeded
xml/Microsoft.JSInterop/JSInProcessRuntime.xml ✅Succeeded
xml/Microsoft.JSInterop/JSInProcessRuntimeExtensions.xml ✅Succeeded
xml/Microsoft.JSInterop/JSInvokableAttribute.xml ✅Succeeded
xml/Microsoft.JSInterop/JSObjectReferenceExtensions.xml ✅Succeeded
xml/Microsoft.JSInterop/JSRuntime.xml ✅Succeeded
xml/Microsoft.JSInterop/JSRuntimeExtensions.xml ✅Succeeded
xml/System.ComponentModel.DataAnnotations/AssociatedMetadataTypeTypeDescriptionProvider.xml ✅Succeeded View
xml/System.Diagnostics/Switch.xml ✅Succeeded View
xml/System.Formats.Cbor/CborConformanceMode.xml ✅Succeeded View
xml/System.Formats.Cbor/CborContentException.xml ✅Succeeded View
xml/System.Formats.Cbor/CborReader.xml ✅Succeeded View
xml/System.Formats.Cbor/CborReaderState.xml ✅Succeeded View
xml/System.Formats.Cbor/CborSimpleValue.xml ✅Succeeded View
xml/System.Formats.Cbor/CborTag.xml ✅Succeeded View
xml/System.Formats.Cbor/CborWriter.xml ✅Succeeded View
xml/System.IO.Compression/BrotliDecoder.xml ✅Succeeded View
xml/System.IO.Compression/BrotliEncoder.xml ✅Succeeded View
xml/System.IO.Compression/BrotliStream.xml ✅Succeeded View
xml/System.IdentityModel.Tokens/GenericXmlSecurityToken.xml ✅Succeeded View
xml/System.IdentityModel.Tokens/SecurityToken.xml ✅Succeeded View
xml/System.Numerics/Matrix3x2.xml ✅Succeeded View
xml/System.Numerics/Matrix4x4.xml ✅Succeeded View
xml/System.Numerics/Plane.xml ✅Succeeded View
xml/System.Numerics/Quaternion.xml ✅Succeeded View

This comment lists only the first 50 files in the pull request.

xml/System.Security.Policy/Evidence.xml

  • Line 0, Column 0: [Warning: ECMA2Yaml_UidAssembly_NotMatched] System.Security.Policy.Evidence's moniker dotnet-plat-ext-6.0 can't match any assembly.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren
Copy link
Contributor Author

@safern @carlossanlop This is good to merge from my POV. Could one of you review it so we can get it merged?

@carlossanlop
Copy link
Contributor

Line 0, Column 0: [Warning: ECMA2Yaml_UidAssembly_NotMatched] System.Security.Policy.Evidence's moniker dotnet-plat-ext-6.0 can't match any assembly.

Do we care about this?

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I was able to reach the docs in the preview for the 3 re-added assemblies.

Only question to answer is the one about the CI warning.

@gewarren
Copy link
Contributor Author

Line 0, Column 0: [Warning: ECMA2Yaml_UidAssembly_NotMatched] System.Security.Policy.Evidence's moniker dotnet-plat-ext-6.0 can't match any assembly.

Do we care about this?

This warning is unrelated to this PR. We have a lot of these warnings in the repo. They'll be addressed by https://dev.azure.com/ceapex/Engineering/_workitems/edit/491194.

@gewarren gewarren merged commit 0047da6 into main Nov 17, 2021
@gewarren gewarren deleted the net6-ga-no-exp branch November 17, 2021 22:26
@gewarren gewarren restored the net6-ga-no-exp branch April 5, 2022 03:10
@gewarren gewarren deleted the net6-ga-no-exp branch April 5, 2022 03:13
@dotnet dotnet deleted a comment from heatherleeann Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants