-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Refresh API docs for .NET 6 GA #7387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=264139&view=results source_repo.branch:net6-ga source_repo.url:https://apidrop.visualstudio.com/_git/binaries
|
Rerunning the CI job after removing the Microsoft.JSInterop.dll assembly, per #7286. |
This comment has been minimized.
This comment has been minimized.
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=264149&view=results source_repo.branch:net6-ga source_repo.url:https://apidrop.visualstudio.com/_git/binaries
This comment has been minimized.
This comment has been minimized.
gewarren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we may want to rerun without the Cbor doc comments.
| <AttributeName Language="F#">[<System.Obsolete("This constructor is obsolete. Use the constructor which accepts arrays of EvidenceBase instead.")>]</AttributeName> | ||
| </Attribute> | ||
| <Attribute FrameworkAlternate="netframework-4.0;netframework-4.5;netframework-4.5.1;netframework-4.5.2;netframework-4.6;netframework-4.6.1;netframework-4.6.2;netframework-4.7;netframework-4.7.1;netframework-4.7.2;netframework-4.8"> | ||
| <Attribute FrameworkAlternate="dotnet-plat-ext-6.0;net-6.0;netframework-4.0;netframework-4.5;netframework-4.5.1;netframework-4.5.2;netframework-4.6;netframework-4.6.1;netframework-4.6.2;netframework-4.7;netframework-4.7.1;netframework-4.7.2;netframework-4.8"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why the specific obsoletion messages got lost here for .NET Framework monikers.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=264548&view=results source_repo.branch:net6-ga source_repo.url:https://apidrop.visualstudio.com/_git/binaries
This comment has been minimized.
This comment has been minimized.
|
@safern @carlossanlop This is good to merge from my POV. Could one of you review it so we can get it merged? |
Do we care about this? |
carlossanlop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I was able to reach the docs in the preview for the 3 re-added assemblies.
Only question to answer is the one about the CI warning.
This warning is unrelated to this PR. We have a lot of these warnings in the repo. They'll be addressed by https://dev.azure.com/ceapex/Engineering/_workitems/edit/491194. |
This refresh includes the following key changes:
Replaces #7384 (we removed the System.Runtime.Experimental package for this pull request).
Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=264139&view=results
source_repo.branch:net6-ga
source_repo.url:https://apidrop.visualstudio.com/_git/binaries