Merged
Conversation
They are supposed to have two (not one) spaces separating the md5 hash and the path as per https://manpages.debian.org/testing/dpkg-dev/deb-md5sums.5.en.html . It seems that upper case hashes are supposed to be allowed, but both `debsums` and `dpkg --verify` seem to complain in practice about the upper case hash so I have also changed it to be lower case.
akoeplinger
approved these changes
Feb 25, 2026
src/arcade/src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateMD5SumsFile.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
akoeplinger
approved these changes
Feb 26, 2026
mthalman
approved these changes
Feb 26, 2026
Member
|
@mthalman should we backport this to 10.0? |
Member
|
/backport to release/10.0.1xx |
Contributor
|
Started backporting to |
Member
|
/backport to release/10.0.2xx |
Member
|
/backport to release/10.0.3xx |
Contributor
|
Started backporting to |
Contributor
|
Started backporting to |
This was referenced Feb 26, 2026
akoeplinger
added a commit
to dotnet/arcade
that referenced
this pull request
Mar 1, 2026
akoeplinger
added a commit
to dotnet/arcade
that referenced
this pull request
Mar 2, 2026
(cherry picked from commit 15d8f1d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are supposed to have two (not one) spaces separating the md5 hash and the path as per https://manpages.debian.org/testing/dpkg-dev/deb-md5sums.5.en.html . It seems that upper case hashes are supposed to be allowed, but both
debsumsanddpkg --verifyseem to complain in practice about the upper case hash so I have also changed it to be lower case.