Conversation
|
I guess it's trying to build the .net sdk from the VMR itself and use it to run the changevalidation tool, but it's failing because it's missing a .net version needed to run the vmr build in the first place? but if I'm not mistaken, this project should only need whatever .net version arcade-services needs (via the DarcLib dependency), so maybe it can be changed to just use .net 10 or something? |
|
@adamzip it was just me messing up the arguments to InitializeDotnetCli when translating from powershell to bash, so it wasn't installing dotnet. I switched to using dotnet.sh since that handles installing+running in one go, but it looks like for some reason it was missing execute permissions (but the failure in the Run Validation Script job shows that it works). |
There was a problem hiding this comment.
Pull request overview
This pull request migrates the validation job in the PR pipeline from Windows to Linux. The changes convert PowerShell commands to bash equivalents and introduce a new dotnet.sh helper script to standardize .NET SDK installation and invocation.
Changes:
- Migrated the validation job from Windows to Linux using Azure Linux pool images
- Converted PowerShell scripts to bash scripts with proper error handling (
set -ex) - Added
eng/common/dotnet.shscript following the established pattern used throughout the repository
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/pipelines/pr.yml | Updated pool configuration to use Linux images and converted validation job scripts from PowerShell to bash |
| eng/common/dotnet.sh | New bash script that installs .NET SDK and invokes it with provided arguments, following the pattern established in subdirectories |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/backport to release/10.0.1xx |
|
Started backporting to |
|
@akoeplinger backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Run validation script job on linux
Using index info to reconstruct a base tree...
M eng/pipelines/pr.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/pr.yml
CONFLICT (content): Merge conflict in eng/pipelines/pr.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Run validation script job on linux
Error: The process '/usr/bin/git' failed with exit code 128 |
No description provided.