Pass -productBuild and -sourceBuild switches#461
Conversation
fa381c0 to
8cd2805
Compare
00b3936 to
4caf2d4
Compare
ViktorHofer
left a comment
There was a problem hiding this comment.
Looks good so far :) Please also pass the source-build switch in here instead of these properties:
dotnet/src/arcade/eng/common/core-templates/steps/source-build.yml
Lines 59 to 60 in f5d6cb4
(The src/arcade eng/common files are the ones that backflow back into Arcade)
|
The prebuilts are coming from aspnetcore when it builds the repotasks separately. You can see that in the repotasks binlog the DotNetBuildSourceOnly=true property isn't part of the MSBuild command line arguments. As I was already looking at this, I updated the sources and pushed a commit. I hope that's OK. cc @wtgodbe - yet another reason to not build repotasks differently and just make them be part of the normal msbuild invocation via a P2P. |
|
OK resolved conflicts with #500. I will now stop touching this PR again ;) |
|
Thanks for your help, Viktor :) Just waiting on the nuget-client changes to flow in, then I'll update this PR and publish it. |
|
If you want to, you can already merge this change. If the content is identical then there won't be any conflicts in the forward-flow PR from nuget and also no backflow into nuget. |
Oh sweet, this is great news. Yes, the changes are identical, so I'll go ahead and merge |
|
🎉🎉🎉 |

Closes dotnet/source-build#4337