Skip to content

Pass -productBuild and -sourceBuild switches#461

Merged
ellahathaway merged 13 commits intodotnet:mainfrom
ellahathaway:ub-switches
May 13, 2025
Merged

Pass -productBuild and -sourceBuild switches#461
ellahathaway merged 13 commits intodotnet:mainfrom
ellahathaway:ub-switches

Conversation

@ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented May 8, 2025

@ellahathaway ellahathaway force-pushed the ub-switches branch 2 times, most recently from fa381c0 to 8cd2805 Compare May 8, 2025 21:38
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far :) Please also pass the source-build switch in here instead of these properties:

/p:DotNetBuildSourceOnly=true \
/p:DotNetBuildRepo=true \

(The src/arcade eng/common files are the ones that backflow back into Arcade)

@ViktorHofer
Copy link
Member

ViktorHofer commented May 13, 2025

The prebuilts are coming from aspnetcore when it builds the repotasks separately.

image

You can see that in the repotasks binlog the DotNetBuildSourceOnly=true property isn't part of the MSBuild command line arguments.


As I was already looking at this, I updated the sources and pushed a commit. I hope that's OK. cc @wtgodbe - yet another reason to not build repotasks differently and just make them be part of the normal msbuild invocation via a P2P.

@ViktorHofer
Copy link
Member

OK resolved conflicts with #500. I will now stop touching this PR again ;)

@ellahathaway
Copy link
Member Author

Thanks for your help, Viktor :)

Just waiting on the nuget-client changes to flow in, then I'll update this PR and publish it.

@ViktorHofer
Copy link
Member

If you want to, you can already merge this change. If the content is identical then there won't be any conflicts in the forward-flow PR from nuget and also no backflow into nuget.

@ellahathaway
Copy link
Member Author

If you want to, you can already merge this change. If the content is identical then there won't be any conflicts in the forward-flow PR from nuget and also no backflow into nuget.

Oh sweet, this is great news. Yes, the changes are identical, so I'll go ahead and merge

@ellahathaway ellahathaway marked this pull request as ready for review May 13, 2025 18:07
@ellahathaway ellahathaway requested review from a team as code owners May 13, 2025 18:07
@ellahathaway ellahathaway enabled auto-merge (squash) May 13, 2025 18:08
@ellahathaway ellahathaway merged commit d780717 into dotnet:main May 13, 2025
11 checks passed
@ellahathaway ellahathaway deleted the ub-switches branch May 13, 2025 18:47
@ViktorHofer
Copy link
Member

🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pass -productBuild and -sourceBuild switches from the VMR orchestrator to the repos instead of /p:DotNetBuildRepo=true and /p:DotNetBuildSourceOnly=true

3 participants