Skip to content

[main] Source code updates from dotnet/aspnetcore#500

Merged
ViktorHofer merged 6 commits intomainfrom
darc-main-e96e207b-66a9-4288-9c05-2efafa0c7506
May 13, 2025
Merged

[main] Source code updates from dotnet/aspnetcore#500
ViktorHofer merged 6 commits intomainfrom
darc-main-e96e207b-66a9-4288-9c05-2efafa0c7506

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 10, 2025

Note

This is a codeflow update. It may contain both source code changes from the source repo as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/aspnetcore

@ViktorHofer
Copy link
Member

This one looks fishy:

Unable to process command ' ##vso[artifact.upload containerfolder=AssetManifests;artifactname=AssetManifests]/__w/1/s/src/aspnetcore/artifacts/log/Release/AssetManifest/Ubuntu2404_Ubuntu_BuildTests_x64.xml' successfully. Please reference documentation (http://go.microsoft.com/fwlink/?LinkId=817296)

@wtgodbe @mmitche PTAL

@wtgodbe
Copy link
Member

wtgodbe commented May 12, 2025

I'm not sure:

Writing build manifest file '/__w/1/s/src/aspnetcore/artifacts/log/Release/AssetManifest/Ubuntu2404_Ubuntu_BuildTests_x64.xml'...

And then right after, when it tries to upload it:

##[error]Path does not exist: /mnt/vss/_work/1/s/src/aspnetcore/artifacts/log/Release/AssetManifest/Ubuntu2404_Ubuntu_BuildTests_x64.xml

is __w an alias for /mnt/vss/_work?

@ViktorHofer
Copy link
Member

The path on Ubuntu is displayed differently because it's running inside a container there and AzDO probably leaks the real path. I don't think that's related as the Windows jobs also fail and they don't run inside a container and the paths are all the same:

Writing build manifest file 'D:\a_work\1\s\src\aspnetcore\artifacts\log\Release\AssetManifest\Windows_x64.xml'...

##[error]Unable to process command ' ##vso[artifact.upload containerfolder=AssetManifests;artifactname=AssetManifests]D:\a_work\1\s\src\aspnetcore\artifacts\log\Release\AssetManifest\Windows_x64.xml' successfully. Please reference documentation (http://go.microsoft.com/fwlink/?LinkId=817296)

##[error]Path does not exist: D:\a_work\1\s\src\aspnetcore\artifacts\log\Release\AssetManifest\Windows_x64.xml

@ViktorHofer
Copy link
Member

ViktorHofer commented May 13, 2025

OK looks like this regressed with @ellahathaway's commit: dotnet/aspnetcore@92bc896

image

@ellahathaway I fixed this with the latest commit by only setting the properties if the args are explicitly provided. I think that's the right thing to do anyway.

@ViktorHofer ViktorHofer enabled auto-merge (squash) May 13, 2025 08:38
@ViktorHofer ViktorHofer merged commit 227febd into main May 13, 2025
15 of 16 checks passed
@ViktorHofer ViktorHofer deleted the darc-main-e96e207b-66a9-4288-9c05-2efafa0c7506 branch May 13, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants