Skip to content

[release/10.0.1xx] Backport change validation pipeline#4409

Merged
premun merged 11 commits intodotnet:release/10.0.1xxfrom
adamzip:port-vmr-change-validation-pipeline
Feb 3, 2026
Merged

[release/10.0.1xx] Backport change validation pipeline#4409
premun merged 11 commits intodotnet:release/10.0.1xxfrom
adamzip:port-vmr-change-validation-pipeline

Conversation

@adamzip
Copy link
Copy Markdown
Contributor

@adamzip adamzip commented Jan 25, 2026

Port the change validation pipeline, which was merged into main last year but not into the release bands

dotnet/arcade-services#5850

adamzip and others added 3 commits January 25, 2026 19:48
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
@adamzip adamzip requested review from a team as code owners January 25, 2026 18:58
@ViktorHofer ViktorHofer changed the title Port vmr change validation pipeline [release/10.0.1xx] Port vmr change validation pipeline Jan 26, 2026
Copy link
Copy Markdown
Member

@premun premun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't merge, we need to revert the test changes (version files etc)

@adamzip
Copy link
Copy Markdown
Contributor Author

adamzip commented Feb 3, 2026

Can't merge, we need to revert the test changes (version files etc)

I don't follow, what are the test changes, and why?
I thought all the changes that are in the PR now are good to go

@premun premun changed the title [release/10.0.1xx] Port vmr change validation pipeline [release/10.0.1xx] Port VMR change validation pipeline Feb 3, 2026
@premun premun changed the title [release/10.0.1xx] Port VMR change validation pipeline [release/10.0.1xx] Backport change validation pipeline Feb 3, 2026
@premun premun self-requested a review February 3, 2026 15:17
@premun premun merged commit 46bef06 into dotnet:release/10.0.1xx Feb 3, 2026
1 of 10 checks passed
@premun
Copy link
Copy Markdown
Member

premun commented Feb 3, 2026

/backport to release/10.0.2xx

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2026

Started backporting to release/10.0.2xx (link to workflow run)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2026

@premun backporting to release/10.0.2xx failed, the patch most likely resulted in conflicts. Please backport manually!

git am output
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Add PR pipeline stage to validate VMR changes
.git/rebase-apply/patch:147: trailing whitespace.
                    ) 
.git/rebase-apply/patch:324: trailing whitespace.
    
.git/rebase-apply/patch:349: trailing whitespace.
    
.git/rebase-apply/patch:396: trailing whitespace.
    string TargetBranch, 
.git/rebase-apply/patch:436: trailing whitespace.
        _dependencyTracker = vmrDependencyTracker;  
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	eng/Version.Details.props
M	eng/Version.Details.xml
M	eng/Versions.props
M	eng/pipelines/pr.yml
M	src/source-mappings.json
Falling back to patching base and 3-way merge...
Auto-merging eng/Version.Details.props
CONFLICT (content): Merge conflict in eng/Version.Details.props
Auto-merging eng/Version.Details.xml
Auto-merging eng/Versions.props
CONFLICT (content): Merge conflict in eng/Versions.props
Auto-merging eng/pipelines/pr.yml
CONFLICT (content): Merge conflict in eng/pipelines/pr.yml
Auto-merging src/source-mappings.json
CONFLICT (content): Merge conflict in src/source-mappings.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Add PR pipeline stage to validate VMR changes
Error: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants