Cloak PFX files in external packages#4107
Merged
NikolaMilosavljevic merged 4 commits intodotnet:mainfrom Jan 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an exclusion pattern to prevent PFX (certificate) files in the source-build-reference-packages external packages from being synchronized into the VMR, resolving s360 security violations.
Key Changes:
- Added wildcard exclusion pattern for all PFX files within the external packages directory
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mthalman
requested changes
Jan 8, 2026
mthalman
approved these changes
Jan 8, 2026
MichaelSimons
pushed a commit
to MichaelSimons/dotnet
that referenced
this pull request
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves s360 violations in VMR for PFX files in
source-build-reference-packagesrepo.