Skip to content

[release/10.0.1xx] Source code updates from microsoft/vstest#3236

Closed
dotnet-maestro[bot] wants to merge 7 commits intorelease/10.0.1xxfrom
darc-release/10.0.1xx-972ff1b0-82c3-43c9-a36d-b0194c216102
Closed

[release/10.0.1xx] Source code updates from microsoft/vstest#3236
dotnet-maestro[bot] wants to merge 7 commits intorelease/10.0.1xxfrom
darc-release/10.0.1xx-972ff1b0-82c3-43c9-a36d-b0194c216102

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 5, 2025 •
edited
Loading

Note

This is a codeflow update. It may contain both source code changes from the source repo as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/microsoft/vstest

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 5, 2025

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance.

@mmitche mmitche enabled auto-merge (squash) November 5, 2025 17:11
@premun
Copy link
Member

premun commented Nov 6, 2025

Same as #3009 (comment)

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 7, 2025

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/product-construction for assistance.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 10, 2025

Important

The source repository has received code changes from an opposite flow. Any additional codeflows into this PR may potentially result in lost changes.

Please continue with one of the following options:

  1. Close or merge this PR and let the codeflow continue normally
  2. Close or merge this PR and receive the new codeflow immediately by triggering the subscription:
    darc trigger-subscriptions --id e9328371-2231-4e19-8729-a16477127d8e
  3. Force-flow new changes into this PR at your own risk (some PR commits might be reverted):
    darc trigger-subscriptions --force --id e9328371-2231-4e19-8729-a16477127d8e

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@mmitche
Copy link
Member

mmitche commented Nov 10, 2025

@nohwnd Some new prebuilts in this:

https://dev.azure.com/dnceng-public/public/public%20Team/_build/results?buildId=1197004&view=logs&j=f8361ec4-8613-5f7f-2f10-d7dd7654e93f&t=db03af06-1031-5cdf-2daa-050507a710e7&l=1607

/__w/1/s/eng/finish-source-only.proj(136,5): error : Microsoft.Build.Framework.17.8.43
/__w/1/s/eng/finish-source-only.proj(136,5): error : Microsoft.Build.Utilities.Core.17.8.43
/__w/1/s/eng/finish-source-only.proj(136,5): error : Microsoft.NET.StringTools.17.8.43
/__w/1/s/eng/finish-source-only.proj(136,5): error : Microsoft.VisualStudio.Setup.Configuration.Interop.3.2.2146
##[error]eng/finish-source-only.proj(136,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) 4 forbidden test usages found in 1 projects:
artifacts/obj/vstest/project-assets-json/obj/Microsoft.TestPlatform.Build/project.assets.json
/__w/1/s/eng/finish-source-only.proj(136,5): error : 4 forbidden test usages found in 1 projects:
/__w/1/s/eng/finish-source-only.proj(136,5): error : artifacts/obj/vstest/project-assets-json/obj/Microsoft.TestPlatform.Build/project.assets.json

@ViktorHofer
Copy link
Member

ViktorHofer commented Nov 10, 2025 •
edited
Loading

Yeah that got fixed via microsoft/vstest#15310 for main. Needs a backport.

@ViktorHofer ViktorHofer mentioned this pull request Nov 10, 2025
Merged
@nohwnd
Copy link
Member

nohwnd commented Nov 11, 2025

#3236

@mmitche
Copy link
Member

mmitche commented Nov 16, 2025

@nohwnd Any update here?

@ViktorHofer
Copy link
Member

ViktorHofer commented Nov 16, 2025 •
edited
Loading

This already got fixed on Tuesday. Here's the official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2835968&view=logs&j=d17d50ef-afac-5d4b-95a6-3014ce5cf7a4&t=21fab4b5-9490-5872-350b-c48d93bf2915

Channels:
- VS 18.0
The following repos/branches will apply this build immediately:
  https://github.com/dotnet/dotnet @ release/10.0.1xx

Apparently something didn't work here as we don't see a new commit in this PR. Pinged dnceng offline to root cause this.

auto-merge was automatically disabled November 17, 2025 08:05

Pull request was closed

@ViktorHofer ViktorHofer deleted the darc-release/10.0.1xx-972ff1b0-82c3-43c9-a36d-b0194c216102 branch November 17, 2025 08:05
@dkurepa dkurepa mentioned this pull request Nov 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmitche mmitche mmitche approved these changes

Assignees

@nohwnd nohwnd

Labels

None yet

Projects

.NET Unified Build
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@premun @mmitche @ViktorHofer @nohwnd