Propagate file mode when re-packing through more archive kinds #2491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
approved these changes
Sep 19, 2025
akoeplinger
approved these changes
Sep 19, 2025
Member
akoeplinger
left a comment
There was a problem hiding this comment.
LGTM but I'd like a second set of eyes from @mmitche
jkoritzinsky
approved these changes
Sep 19, 2025
mmitche
approved these changes
Sep 19, 2025
Member
|
@jjonescz I think this needs to be ported to main |
Member
Author
|
/backport to main |
Contributor
|
Started backporting to |
Contributor
|
@jjonescz backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Set unix file mode when extracting as well
Using index info to reconstruct a base tree...
M src/arcade/src/Microsoft.DotNet.SignTool/src/Configuration.cs
M src/arcade/src/Microsoft.DotNet.SignTool/src/ZipData.cs
Falling back to patching base and 3-way merge...
Auto-merging src/arcade/src/Microsoft.DotNet.SignTool/src/Configuration.cs
Auto-merging src/arcade/src/Microsoft.DotNet.SignTool/src/ZipData.cs
CONFLICT (content): Merge conflict in src/arcade/src/Microsoft.DotNet.SignTool/src/ZipData.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Set unix file mode when extracting as well
Error: The process '/usr/bin/git' failed with exit code 128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/sdk#50881.
Follow up on #2425.
Related to dotnet/roslyn#80151.
Official build validation run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2797161&view=results
.pkgartifact containscscwith +x mode, so this should fix the linked issue.