Skip to content

Add es-metadata.yml for each repo in the VMR.#2376

Merged
mmitche merged 5 commits intodotnet:mainfrom
mmitche:inventory-as-code
Sep 12, 2025
Merged

Add es-metadata.yml for each repo in the VMR.#2376
mmitche merged 5 commits intodotnet:mainfrom
mmitche:inventory-as-code

Conversation

@mmitche
Copy link
Copy Markdown
Member

@mmitche mmitche commented Sep 11, 2025

No description provided.

@mmitche
Copy link
Copy Markdown
Member Author

mmitche commented Sep 11, 2025

@artl93 @shawnro @jamshedd

@mmitche mmitche requested a review from artl93 September 11, 2025 17:56
@mmitche
Copy link
Copy Markdown
Member Author

mmitche commented Sep 11, 2025

Part of dotnet/arcade-services#2362

Copy link
Copy Markdown
Member

@artl93 artl93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. There are a few routing issues that should be looked at.

Thanks!

@artl93
Copy link
Copy Markdown
Member

artl93 commented Sep 11, 2025

@mmitche - Who owns https://github.com/dotnet/dotnet/eng? I'd like as little as possible to go to .NET VMR as possible.

Copy link
Copy Markdown
Member

@artl93 artl93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing this!

@mmitche
Copy link
Copy Markdown
Member Author

mmitche commented Sep 11, 2025

@mmitche - Who owns https://github.com/dotnet/dotnet/eng? I'd like as little as possible to go to .NET VMR as possible.

That one seems like it should probably go into the shared VMR entry. It's a mix of source build, VMR infra, arcade templates and common scripting, etc.

@artl93
Copy link
Copy Markdown
Member

artl93 commented Sep 11, 2025

@jeffschwMSFT @artl93 @shawnro @jamshedd @siramvikram - please be aware that this is likely to have a disruptive impact on issue routing in s360. This change will have the side effect that this repo will no longer be 1:1 with service tree and are likely going to break tool assumptions. That said issues will be automatically sent to teams, which is a benefit.

@artl93
Copy link
Copy Markdown
Member

artl93 commented Sep 11, 2025

@mmitche - Who owns https://github.com/dotnet/dotnet/eng? I'd like as little as possible to go to .NET VMR as possible.

That one seems like it should probably go into the shared VMR entry. It's a mix of source build, VMR infra, arcade templates and common scripting, etc.

Umm... @mmitche - wouldn't that infer that we need one of these magic files in the root then pointing to the VMR entry?

@mmitche
Copy link
Copy Markdown
Member Author

mmitche commented Sep 12, 2025

@mmitche - Who owns https://github.com/dotnet/dotnet/eng? I'd like as little as possible to go to .NET VMR as possible.

That one seems like it should probably go into the shared VMR entry. It's a mix of source build, VMR infra, arcade templates and common scripting, etc.

Umm... @mmitche - wouldn't that infer that we need one of these magic files in the root then pointing to the VMR entry?

There is. It was originally in src but was moved in this PR to the root.

@mmitche mmitche enabled auto-merge (squash) September 12, 2025 15:10
@mmitche mmitche merged commit bf47641 into dotnet:main Sep 12, 2025
11 checks passed
routing:
defaultAreaPath:
org: devdiv
path: "DevDiv\NET Libraries"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmitche you missed the quotes on this one

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agh..how...

@mmitche
Copy link
Copy Markdown
Member Author

mmitche commented Sep 29, 2025

/backport to release/10.0.1xx

@github-actions
Copy link
Copy Markdown
Contributor

Started backporting to release/10.0.1xx: https://github.com/dotnet/dotnet/actions/runs/18100970065

@github-actions
Copy link
Copy Markdown
Contributor

@mmitche backporting to "release/10.0.1xx" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Add es-metadata.yml for each repo in the VMR.
error: mode change for src/es-metadata.yml, which is not in current HEAD
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Add es-metadata.yml for each repo in the VMR.
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@mmitche mmitche deleted the inventory-as-code branch September 29, 2025 14:59
mmitche added a commit to mmitche/dotnet that referenced this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants