Merged
Conversation
ViktorHofer
reviewed
Jun 30, 2025
ViktorHofer
reviewed
Jun 30, 2025
ViktorHofer
reviewed
Jun 30, 2025
ViktorHofer
reviewed
Jun 30, 2025
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
ViktorHofer
approved these changes
Jun 30, 2025
akoeplinger
pushed a commit
to dkurepa/dotnet
that referenced
this pull request
Jul 3, 2025
(cherry picked from commit 15fbd58)
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1110
This updates the UB pipeline to publish source built artifacts. This is necessary in order for source-only builds of the 2xx branch to be able to consume the packages that were produced by the 1xx branch. For example, the 1xx branch would produce the System.Text.Json package from the runtime repo which can then be pulled in as a dependency for the 2xx branch's source build, since runtime source isn't included in that branch.
Originally I tried to include the artifacts tarball in the existing VerticalManifest.xml file that gets produced by a source-only job. That's problematic because of a chicken-and-egg problem. The artifacts tarball includes the VerticalManifest.xml file in it. But since we want the VerticalManifest.xml file to include a reference to this tarball, we can't produce the VerticalManifest.xml file without the artifacts tarball already existing.
Instead a different approach is taken where a separate manifest file is produced. This allows the artifacts tarball to be produced after the VerticalManifest.xml file just as before. And then a new manifest file gets generated that only references the artifacts tarball. This is done by making two passes of the
Publishtarget, referencing different manifests and configuration to include the appropriate files.Prior to these changes all manifests from source-only jobs were excluded from the processing in the
Publishstage. These changes update that to specifically exclude the original VerticalManifest.xml file and only include the manifest file containing the artifacts tarball, whose name is based on the job name for uniqueness purposes.Some other things that needed to be fixed with these changes:
-Eoption tosudoin order to flow the system environment variables to the build. Without this option set, AzDO variables likeBUILD_BUILDIDwere not set which are necessary in order to produce a correct manifest file.FilesToPublishToSymbolServeritems for source-only builds. These symbols shouldn't be published for source-only and were incorrectly showing up in the manifests for the artifacts tarball without these changes.