Improve formatting and technical info re: Signing Stored Procedures #4063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Made formatting more consistent 2. Rearranged a few paragraphs to have a more natural / logical flow 3. Added missing info, such as what types of modules can be signed 4. Replaced note about logins for server-level permissions with login-related info throughout since both database-level and server-level really need to be presented as working together, equally, and that you can have one or both (the way it was presented almost seemed to imply that it was one or the other) Resources to confirm the additions and changes: * https://ModuleSigning.info/ * https://sqlquantumleap.com/2017/12/30/please-please-please-stop-using-impersonation-execute-as/
|
|
Contributor
|
@douglaslMS this is a PR for an ADO.NET topic. Can you please review it? /cc @craigg-msft |
Contributor
|
@srutzky Thank you for improving this article! |
Contributor
|
#sign-off |
douglaslMS
approved these changes
Jan 26, 2018
Contributor
|
@douglaslMS you should join the dotnet org so I can give you write permissions to our repo. I'll follow up with you offline. (and we don't have PRMerger here 😄) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources to confirm the additions and changes: