Skip to content

Update .NET Standard overview for .NET 5#20955

Merged
tdykstra merged 7 commits intodotnet:masterfrom
tdykstra:netstd
Oct 13, 2020
Merged

Update .NET Standard overview for .NET 5#20955
tdykstra merged 7 commits intodotnet:masterfrom
tdykstra:netstd

Conversation

@tdykstra
Copy link
Contributor

@tdykstra tdykstra commented Oct 6, 2020

@tdykstra tdykstra changed the title WIP: Update .NET Standard overview for .NET 5 Update .NET Standard overview for .NET 5 Oct 8, 2020
@tdykstra tdykstra marked this pull request as ready for review October 8, 2020 21:53
@tdykstra tdykstra requested review from a team and gewarren as code owners October 8, 2020 21:53
@tdykstra tdykstra requested review from BillWagner and terrajobst and removed request for a team October 8, 2020 21:57
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for these updates. These are crucial for the .NET 5 release.

tdykstra and others added 3 commits October 9, 2020 11:19
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@tdykstra tdykstra merged commit 66122a1 into dotnet:master Oct 13, 2020
@tdykstra tdykstra deleted the netstd branch October 13, 2020 22:34
| .NET Standard | [1.0] | [1.1] | [1.2] | [1.3] | [1.4] | [1.5] | [1.6] | [2.0] | [2.1] |
|----------------------------|--------|--------|-------|-------|-------|--------------------|--------------------|---------------------|---------------------
| .NET Core | 1.0 | 1.0 | 1.0 | 1.0 | 1.0 | 1.0 | 1.0 | 2.0 | 3.0 |
| .NET Core and .NET 5 | 1.0 | 1.0 | 1.0 | 1.0 | 1.0 | 1.0 | 1.0 | 2.0 | 3.0 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually adding .NET as a new line to the .NET website. Should we be consistent?

https://github.com/dotnet/website/pull/2351

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll start a new PR to do that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought that would change the structure of the table or make its labeling inaccurate --

The rows represent the different .NET implementations.

.NET Core and .NET 5 are the same implementation of .NET, so putting them on separate lines would be misleading.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would make https://dotnet.microsoft.com/platform/dotnet-standard and docs mismatch. Also, you're adding a product version into the label, when .NET is itself a target.

/cc @terrajobst

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have the same problem with the table on https://dotnet.microsoft.com/platform/dotnet-standard -- the column header for the first column is ".NET Implementation" -- not "target" as in TFM. The table as a result presents ".NET Core" and ".NET" as two separate implementations of .NET when in fact they are one and the same. That's likely to cause confusion. We should either tweak the column heading (in the dotnet site) and the table description (in the docs.microsoft.com site) or use just one line for Core and 5 in both places.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thought occurred to me -- do we still need two versions of this table, or could we remove the docs.ms.com one and just link to the dotnet site one from the docs.ms.com article?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, what will you do when .NET 6 comes out? Add it to the name of the implementation even though we only list minimum versions?
I agree they are the same implementation, but now they have different names, so I thought it warranted a new line.
I could include this in a series of user studies that we're planning to do as well.
I'd be concerned about removing this table from the docs. I hate having to make customers go to another place to find the information they need. This article has 30k page views last month and only ~500 clicked on the interactive table link.

Copy link
Contributor

@terrajobst terrajobst Oct 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I agree with @tdykstra. We should treat .NET 5 as rebranded .NET Core 4, that is it should be in the row as .NET Core. Otherwise, we have to explain how .NET 5 is different from .NET Core :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Then I'll tweak the marketing site so both sites match.

BillWagner added a commit that referenced this pull request Oct 14, 2020
* Respond to feedback for deserialization constructors (#21051)

* Fixes #20949. (#21052)

* Add f1-keyword for `class` used as generic type constraint (#21037)

* Add f1-keyword for `class` used as generic type constraint

* Add structconstraint

* Update CS0267 message and simplify example (#21047)

* Update CS0267 message and simplify example

* Update ms.date

* Added a link (#21058)

* Fixes #20958. (#21054)

* fix the source path for retired C# 7.x content (#21059)

The "whats-new" folder was missing.

* Removing redundant pipe character (#20931)

* Update single-file.md (#20925)

update ReadyToRun link now that we have the docs for it.

* Remove statement about TLS 1.3 for .NET Core 3.0 (#20922)

I think, TLS 1.3 won't be supported by .NET Core 3.0 since it's out of support and the implementation is coming with .NET 5, as stated in [Transport Layer Security (TLS) best practices with the .NET Framework](#4675 (comment)).

This info should be removed, so we have no misleading information out there... 😉

* SslStream/NegotiateStream breaking change (#20979)

* Add workload and app model to glossary (#21046)

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Breaking change for key-value pair serialization (#21050)

* Update .NET Standard overview for .NET 5 (#20955)

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Update get-started-vscode.md (#21072)

http to https after verifying link

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Jon Senchyna <TheSench@users.noreply.github.com>
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
Co-authored-by: William Whitwell Bailey <45574209+willwhitwellbailey@users.noreply.github.com>
Co-authored-by: Lakshan Fernando <lakshanf@hotmail.com>
Co-authored-by: kapsiR <kapsiR@users.noreply.github.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: icyfire0573 <40814526+icyfire0573@users.noreply.github.com>
@tdykstra
Copy link
Contributor Author

what will you do when .NET 6 comes out?

Use the approved naming pattern for docs -- .NET 5 (and .NET Core) and later versions

Until 3.1 goes out of support. Could do that now but it's unnecessarily long since there's nothing after 5 yet and this is a file that will get updated with each release.

@tdykstra tdykstra mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update standard/choosing-core-framework-server.md for .NET 5 Update .NET Architectural Components for .NET 5 Update .NET Standard intro for .NET 5

5 participants