Skip to content

refactor: build command project consolidation #9277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yufeih merged 3 commits into from
Oct 9, 2023
Merged

refactor: build command project consolidation #9277

yufeih merged 3 commits into from
Oct 9, 2023

Conversation

@yufeih
Copy link
Contributor

@yufeih yufeih commented Oct 9, 2023

Consolidate build related projects by:

  • Renaming Docfx.Build.Engine -> Docfx.Build
  • Merge core build functionalities (Docfx.Build.ConceptualDocuments, Docfx.Build.TableOfContents, Docfx.Build.ResourceFiles) into Docfx.Build
  • Move others into the extensions solution folder (ManagedReference, UniversalReference, SchemaDriven, OverwriteDocuments, RestApi)

@yufeih yufeih marked this pull request as ready for review October 9, 2023 07:39
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...rationLevelRestApi/SplitRestApiToOperationLevel.cs 98.07% <ø> (ø)
...fx.Build.TagLevelRestApi/SplitRestApiToTagLevel.cs 96.00% <ø> (ø)
src/Docfx.Build/BuildPhaseUtility.cs 100.00% <ø> (ø)
src/Docfx.Build/CompilePhaseHandler.cs 94.00% <ø> (ø)
src/Docfx.Build/CompositionContainer.cs 66.66% <ø> (ø)
.../Docfx.Build/Conceptual/BuildConceptualDocument.cs 87.87% <ø> (ø)
...fx.Build/Conceptual/ConceptualDocumentProcessor.cs 94.64% <ø> (ø)
src/Docfx.Build/Conceptual/CountWord.cs 100.00% <ø> (ø)
src/Docfx.Build/Conceptual/HtmlDocumentUtility.cs 100.00% <ø> (ø)
src/Docfx.Build/Conceptual/SeparatedHtmlInfo.cs 100.00% <ø> (ø)
... and 88 more

... and 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@yufeih yufeih merged commit 9570d45 into main Oct 9, 2023
@yufeih yufeih deleted the resmd branch October 9, 2023 07:48
@yufeih yufeih added new-feature Makes the pull request to appear in "New Features" section of the next release note engineering Makes the pull request to appear in the "Engineering" section of the next release note and removed new-feature Makes the pull request to appear in "New Features" section of the next release note labels Oct 18, 2023
@chenrui333 chenrui333 mentioned this pull request Oct 18, 2023
Merged
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
@yufeih @p-kostov
refactor: build command project consolidation (dotnet#9277)
28084b0
@emmanuel-ferdman emmanuel-ferdman mentioned this pull request Sep 27, 2024
Merged
@dependabot dependabot bot mentioned this pull request Dec 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

engineering Makes the pull request to appear in the "Engineering" section of the next release note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yufeih