Skip to content

Fix issue running under netcore 2.0 #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vicancy merged 2 commits into from
Dec 1, 2017
Merged

Fix issue running under netcore 2.0 #2248

vicancy merged 2 commits into from
Dec 1, 2017

Conversation

@vicancy
Copy link
Contributor

@vicancy vicancy commented Dec 1, 2017

Fix #1752 (comment)

  1. Add necessary env, use dotnet --info to get current default dotnet base path
  2. Add config settings, according to https://github.com/Microsoft/msbuild/blob/6851538897f5d7b08024a6d8435bc44be5869e53/src/Build/Definition/ToolsetReader.cs#L294, config settings takes over registry and over local assembly version.

superyyrrzz
superyyrrzz approved these changes Dec 1, 2017
View reviewed changes
Copy link
Contributor

@superyyrrzz superyyrrzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@vicancy vicancy merged commit 7e5802e into dotnet:dev Dec 1, 2017
@vicancy vicancy deleted the ff branch December 1, 2017 04:06
vicancy added a commit that referenced this pull request Dec 1, 2017
@vicancy
Fix issue running under netcore 2.0 (#2248)
c737b88 
* Fix issue running under netcore 2.0

* catch exception with dotnet --info
@rainersigwald rainersigwald mentioned this pull request Mar 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@superyyrrzz superyyrrzz superyyrrzz approved these changes

@hellosnow hellosnow Awaiting requested review from hellosnow

@herohua herohua Awaiting requested review from herohua

@928PJY 928PJY Awaiting requested review from 928PJY

+1 more reviewer

@vwxyzh vwxyzh vwxyzh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vicancy @vwxyzh @superyyrrzz