Update the required members spec by 333fred · Pull Request #5566 · dotnet/csharplang

333fred · 2021-12-23T00:37:43Z

Adds some additional details on various topics, including OHI and metadata. Also adds new questions for LDM to address in a full session in early Jan.

Relates to test plan dotnet/roslyn#57046

Adds some additional details on various topics, including OHI and metadata. Also adds new questions for LDM to address in a full session in early Jan.

333fred · 2021-12-23T00:38:08Z

@jcouv @RikkiGibson for review.

Adding `required` to a member now results in the type having a `RequiredMembersAttribute` emitted with the name of that member as the contents. Reading this data from metadata is not yet supported, nor is adding the requisite `ObsoleteAttribute` to constructors that depend on such contracts. The rules for when required is allowed and when it is disallowed are documented in dotnet/csharplang#5566, pending LDM review. Test plan: dotnet#57046

proposals/required-members.md

jcouv · 2022-01-04T18:53:38Z

proposals/required-members.md

+}
+```
+
+It is an error to hide a `required` member, as that member can no longer be set by a consumer.


nit: I don't know if Mads or someone else has created a proposal for addressing members of specific types (something like x.(Type.Method)(argument)). If there's one, let's add a note there about this scenario.

@MadsTorgersen?

proposals/required-members.md

jcouv

Done with review pass (iteration 1)

jcouv

LGTM Thanks (iteration 2)

…dates * upstream/main: Add example of when field initializers will not be run for option 3. Correct link Added LDM notes for January 3rd, 2022. Update README.md Update LDM agenda Fix line wrapping (dotnet#5589) Update raw-string-literal.md 'record struct' constructor requires 'this' initializer that calls primary constructor or explicit constructor (dotnet#5562) Tweak readonly backing field wording (dotnet#5583) Update semi auto props spec around readonly backing field for init-only (dotnet#5582) Spec change around backing field being readonly (dotnet#5575)

* upstream/main: Update LDM agenda Added LDM Notes for January 5th, 2022. Update the required members spec (dotnet#5566) Add example of when field initializers will not be run for option 3. Correct link Added LDM notes for January 3rd, 2022. Update README.md Update LDM agenda Fix line wrapping (dotnet#5589) Update raw-string-literal.md 'record struct' constructor requires 'this' initializer that calls primary constructor or explicit constructor (dotnet#5562) Tweak readonly backing field wording (dotnet#5583) Update semi auto props spec around readonly backing field for init-only (dotnet#5582) Spec change around backing field being readonly (dotnet#5575)

Adding `required` to a member now results in the type having a `RequiredMembersAttribute` emitted with the name of that member as the contents. Reading this data from metadata is not yet supported, nor is adding the requisite `ObsoleteAttribute` to constructors that depend on such contracts. The rules for when required is allowed and when it is disallowed are documented in dotnet/csharplang#5566, pending LDM review. Test plan: dotnet#57046

Adding `required` to a member now results in the type having a `RequiredMemberAttribute` emitted on the member and the containing type. Reading this data from metadata is not yet supported, nor is adding the requisite `ObsoleteAttribute` to constructors that depend on such contracts. The rules for when required is allowed and when it is disallowed are documented in dotnet/csharplang#5566. Test plan: #57046

Update the required members spec

a0b70f1

Adds some additional details on various topics, including OHI and metadata. Also adds new questions for LDM to address in a full session in early Jan.

333fred requested a review from a team as a code owner December 23, 2021 00:37

333fred requested review from RikkiGibson and jcouv December 23, 2021 00:38