This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Merged
Conversation
1) Refactor ComputeLookup to pass around references to the CORINFO_RESOLVED_TOKEN instead of its tokenContext. This will be needed in the next change to implement R2R variants of the methods. 2) Add new CanInline method to the Compilation class to be used by CorInfoImpl to query inline-ability. Thanks Tomas
MichalStrehovsky
approved these changes
Jul 20, 2018
Member
MichalStrehovsky
left a comment
There was a problem hiding this comment.
Looks good otherwise, thanks!
src/JitInterface/src/CorInfoImpl.cs
Outdated
| using Internal.TypeSystem; | ||
|
|
||
| using Internal.IL; | ||
| using Internal.JitInterface; |
Member
Author
There was a problem hiding this comment.
Hmm, probably just some copy & paste bug, will remove.
Member
Author
|
Thanks Michal for the quick review! Tomas |
trylek
added a commit
to trylek/corert
that referenced
this pull request
Oct 1, 2018
* CorInfoImpl refactoring part #1 1) Refactor ComputeLookup to pass around references to the CORINFO_RESOLVED_TOKEN instead of its tokenContext. This will be needed in the next change to implement R2R variants of the methods. 2) Add new CanInline method to the Compilation class to be used by CorInfoImpl to query inline-ability. Thanks Tomas * Remove superfluous "using Internal.JitInterface" from CorInfoImpl
trylek
added a commit
to trylek/corert
that referenced
this pull request
Oct 15, 2018
* CorInfoImpl refactoring part #1 1) Refactor ComputeLookup to pass around references to the CORINFO_RESOLVED_TOKEN instead of its tokenContext. This will be needed in the next change to implement R2R variants of the methods. 2) Add new CanInline method to the Compilation class to be used by CorInfoImpl to query inline-ability. Thanks Tomas * Remove superfluous "using Internal.JitInterface" from CorInfoImpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor ComputeLookup to pass around references to the
CORINFO_RESOLVED_TOKEN instead of its tokenContext. This will be
needed in the next change to implement R2R variants of the methods.
Add new CanInline method to the Compilation class to be used
by CorInfoImpl to query inline-ability.
Thanks
Tomas