This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Merged
Conversation
Contributor
Author
Contributor
Author
jkotas
reviewed
Apr 25, 2017
| <DefineConstants>ARM;$(DefineConstants)</DefineConstants> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(Platform)' == 'armel'"> | ||
| <DefineConstants>ARMEL;$(DefineConstants)</DefineConstants> |
Member
There was a problem hiding this comment.
In CoreCLR, we are defining ARM for armel. We should do the same here.
Member
There was a problem hiding this comment.
Or maybe even rewrite armel to arm at the top like it is done for CoreCLR: https://github.com/dotnet/coreclr/blob/master/src/mscorlib/System.Private.CoreLib.csproj#L16
jkotas
reviewed
Apr 25, 2017
src/JitInterface/src/CorInfoImpl.cs
Outdated
| return 0x8664; // AMD64 | ||
| TargetArchitecture arch = _compilation.TypeSystemContext.Target.Architecture; | ||
|
|
||
| if (arch == TargetArchitecture.X86) |
jkotas
approved these changes
Apr 25, 2017
Member
|
Thanks! |
MichalStrehovsky
added a commit
to MichalStrehovsky/corert
that referenced
this pull request
Apr 26, 2017
The way we were setting common defines (such as `AMD64`, `BIT64`, `ARM`) was extremely fragile and invited partial fixes such as dotnet#3414 and dotnet#3424. This really needs to be centralized.
jkotas
pushed a commit
that referenced
this pull request
Apr 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.