This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Conversation
Noticed this while doing the pointer array work. Turns out *step through `typeof(Foo).MakeByRefType()` in a debugger and then find all other occurences of "IsPointer" "is Pointer", "is Parameterized" and update accordingly* is not a good strategy to write type loader code. [tfs-changeset: 1653281]
Merge changes from TFS
* Add CoreRT implementation for the dynamic invoke template table which maps invoke stub name / sig to the canonical method entrypoint * CoreRT based compilers use 32bit relative addresses to the stub containing EEType and method entry points (.NET Native uses RVAs). Set the bit on the reloc to indicate a 32bit rel reloc. * Fix a bug in generic method template map where generic methods on structs were getting IsUnboxingStub set incorrectly [tfs-changeset: 1653288]
Merge changes from TFS
The dynamic invoke tests were failing because the JIT was inlining all the target methods leaving nothing to actually invoke through reflection. Mark all the methods we invoke (including the empty constructors) with `[MethodImpl(MethodImplOptions.NoInlining)]`. [tfs-changeset: 1653296]
Merge changes from TFS
Member
|
@dotnet-bot test OSX Debug and CoreCLR tests please |
[tfs-changeset: 1653409]
Fix #2588 Port of SymCryptMarvin32() from marvin.cpp. https://github.com/dotnet/coreclr/blob/master/src/vm/marvin32.cpp#L219 - Tested on various seeds and data arrays up to 30 bytes long. (test data obtained by hacking CoreCLR to get test data with deterministic seeds.) - s0/s1 renamed to p0/p1 (for more consistency with algorithm description in patent.) - Verified that NUTC generates fully inlined code for Marving.ComputeHashString() (including reducing _rotl to rol or ror.) - Marvin specifies interpreting bytes in little-endian fashion - if this code ever runs on a big-endian machine, the result is probably not Marvin (though I can see how it's any less useful for the way we use it.) - This is not turned on by default (we don't yet have a switch to turn on randomized string hashing in CoreRT).
Merge changes from TFS
Member
Author
|
@cshung Are you set up to have a look at the CoreRT build breaks caused by your change? There's independent breakage in both Unix builds and Windows builds. |
Contributor
|
I am on it. |
[tfs-changeset: 1653426]
Merge changes from TFS
[tfs-changeset: 1653494]
[tfs-changeset: 1653496]
ObjectInvariant - an obsolete method for supporting contracts... CreateWaitHandle - not too useful by itself, but I assume this was meant to be overridden by something more useful. Synchronized - creates SyncStream. - Keeping Stream structured the same as the CoreCLR version. Not going to attempt to share this as there still lots of scary looking async differences. I'll leave this to the area owner.
Merge changes from TFS
[tfs-changeset: 1653504]
Merge changes from TFS
Contributor
|
This passed SimonCI locally on my Mac so just merging. |
dotnet-bot
pushed a commit
to dotnet/coreclr
that referenced
this pull request
Apr 7, 2017
Merge nmirror to master Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/coreclr
that referenced
this pull request
Apr 7, 2017
Merge nmirror to master Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
|
I think this resulting in Is there a corresponding dotnet/corefx PR ready to resolve this? |
|
@brianrob see last comment. |
Member
|
I am going to submit one. |
|
@jkotas Thanks. Looks like it just hit: dotnet/corefx#18167 |
Member
|
@RussKeldorph, is this failing in coreclr, corefx or corert? I'm not 100% sure from the message above. |
Member
|
Ok, thank you. @jkotas if you need me to handle this, just let me know and I'll jump in. |
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 13, 2018
Merge nmirror to master Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com> Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 13, 2018
Merge nmirror to master Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com> Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
safern
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 16, 2018
Merge nmirror to master Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com> Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
safern
pushed a commit
to dotnet/corefx
that referenced
this pull request
Jan 16, 2018
Merge nmirror to master Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com> Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.