This repository was archived by the owner on Aug 2, 2023. It is now read-only.
Attempts at improving encoding performance of UTF8.TryEncodeFromUtf16 #1113
Merged
KrzysztofCwalina merged 5 commits intodotnet:masterfrom Jan 14, 2017
Merged
Attempts at improving encoding performance of UTF8.TryEncodeFromUtf16 #1113KrzysztofCwalina merged 5 commits intodotnet:masterfrom
KrzysztofCwalina merged 5 commits intodotnet:masterfrom
Conversation
Contributor
Author
|
@dotnet-bot test this please |
0a317b7 to
8cf7034
Compare
…while source code shows BE for readability)
Contributor
Author
|
cc @KrzysztofCwalina Please review. |
ahsonkhan
added a commit
to ahsonkhan/corefxlab
that referenced
this pull request
Jan 28, 2017
…dotnet#1113) * Attempts at improving performance of TryEncodeFromUtf16 * Fixing implementation to take in little endian UTF16 characters - Also added surrogate logic * Removing incorrect byte ordering conversion since System.Char is LE (while source code shows BE for readability) * Removing unnecessary optional parameter for LE in perf test. * Minor changes to improve perf, not writing directly to out param.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing implementation to take in little endian UTF16 characters and adjusting tests so they use UTF16 LE bytes.
Switching EncodingPerfComparisonTests to use the TextEncoder.Utf8.TryEncodeFromUtf16 method. It should be 3x slower instead of 7x slower now.
As part of Issue #1091 - Productize Encoding APIs