This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Merged
Conversation
clean.sh only needs to call init-tools.sh when it is going to use MSBuild. A corresponding change was made to clean.cmd in dotnet@fe967b3 Specifying a substring using a negative length is only supported on Bash 4.2 and later. Some machines may have an older version of Bash (e.g. on Mac OS X), so we should avoid using it.
Member
Author
|
I've added a second fix to this PR. Specifying a substring using a negative length is only supported on Bash 4.2 and later. Some machines may have an older version of Bash (e.g. on Mac OS X), so we should avoid using it. |
Member
|
Looks like the CI failures are due to test failures but I don't think they are related to your change. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clean.sh only needs to call init-tools.sh when it is going to use MSBuild. A corresponding change was made to clean.cmd in fe967b3.
cc: @maririos @joperezr @weshaggard