This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Don't get available bytes for the socket unless we actually need the result#6835
Merged
ericeil merged 1 commit intodotnet:masterfrom Mar 11, 2016
Merged
Don't get available bytes for the socket unless we actually need the result#6835ericeil merged 1 commit intodotnet:masterfrom
ericeil merged 1 commit intodotnet:masterfrom
Conversation
…result While reading through the code I noticed that we're making unnecessary `ioctl` calls in Receive calls, to get the count of available bytes. This turns out to only be used if the caller supplied a list of buffers, which is not the typical case. This change moves the `ioctl` call so that it happens only if needed, which should help with throughput in most scenarios.
Member
|
Nice. LGTM. |
ericeil
added a commit
that referenced
this pull request
Mar 11, 2016
Don't get available bytes for the socket unless we actually need the result
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Don't get available bytes for the socket unless we actually need the result Commit migrated from dotnet/corefx@56aacbe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading through the code I noticed that we're making unnecessary
ioctlcalls in Receive calls, to get the count of available bytes. This turns out to only be used if the caller supplied a list of buffers, which is not the typical case. This change moves theioctlcall so that it happens only if needed, which should help with throughput in most scenarios.@stephentoub