Let's add "skiptests" option to support optional compilation
on test files (e.g. *Tests.dll and *Tests.pdb) of corefx.

/cc @stephentoub , @jkotas, @benpye , @myungjoo, @prajwal-aithal

There's another reason for this too: when the build tools version changes, it's not possible to build a single project anymore. You have to kick off the root build instead to grab the new tools/initialize them...

You have to kick off the root build instead to grab the new tools/initialize them...

@Clockwork-Muse Do you mean ./clean.sh ?

@leemgs - it's possible that would work, I haven't tried it (easy to test though). When the new tools version shows up trying to build a single project complains about some other file not being present (one of the .dir or .props, can't recall). So I wouldn't have anticipated something labeled "clean" pulling down the correct version (given how cleaning builds normally just removes all built objects, as near as I understand).

What's the benefit over just using build.sh /p:SkipTests=true right now?

What's the benefit over just using build.sh /p:SkipTests=true right now?

@akoeplinger, Good question. When embedded guys try to build managed corefx on their local PC after modifying/updating a source code of the corefx for some enhancements, they have to wait for a long time until build.sh command finish all compilation procedures. This patch helps to skip the test procedure alternatively to save their time. It is motivated from skiptests option of the coreCLR.

@leemgs what I meant was that build.sh /p:SkipTests=true works already with the current version, because all unrecognized parameters to build.sh are passed along to msbuild, so skipping tests is already possible without an additional skiptests.

But if the option makes the script more consistent with CoreCLR then I think it's worthwhile 👍

@akoeplinger, Right. That is why. As you mentioned, build.sh skiptests is better than build.sh /p:SkipTests=true in order to keep more consistent usage between coreCLR and coreFX for Linux-based platform developers.

LGTM

From my own experience, this option is very convenient for people moving accross coreclr/corert and corefx repos. I tend to accidentally run build.sh skiptests myself in corefx too.

+1 for consistency between corefx/coreclr build scripts.

LGTM