This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Move System.Text.RegularExpressions tests to xunit#6515
Merged
stephentoub merged 1 commit intodotnet:masterfrom Mar 18, 2016
hughbe:regex-test-cleanup
Merged
Move System.Text.RegularExpressions tests to xunit#6515stephentoub merged 1 commit intodotnet:masterfrom hughbe:regex-test-cleanup
stephentoub merged 1 commit intodotnet:masterfrom
hughbe:regex-test-cleanup
Conversation
This commit moves the tests for System.Text.RegularExpressions to use xunit, instead of Console.WriteLine and really obfuscated error messages. I have not added or removed any tests.
| ++iCountErrors; | ||
| Console.WriteLine("Error Err_8888yyy! strLoc==" + strLoc + ", exc_general==" + exc_general.ToString()); | ||
| Assert.True(s_regexTests[i].Run()); | ||
| } |
Member
There was a problem hiding this comment.
Seems like this RegexTestClass thing can be unraveled in the future, but for now, should this be a theory? e.g.
[Theory]
[MemberData(nameof(CharacterClassSubtractionTestCases))]
public void CharacterClassSubtraction(RegexTestCase case)
{
case.Run();
}?
Member
|
Thanks, @hughbe. What you've done here is a definite improvement over what was there before. Thanks! I do think there's more cleanup to be done; up to you whether you want to do that as part of this PR, or leave it for you / someone else for a future time. |
Author
|
Yeah, I've got a lot more cleanup to do here! |
stephentoub
added a commit
that referenced
this pull request
Mar 18, 2016
Move System.Text.RegularExpressions tests to xunit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit moves the tests for System.Text.RegularExpressions to use
xunit, instead of Console.WriteLine and really obfuscated error messages.
I have not added or removed any tests. I did, however, remove some obsolete test code for branches that would never occur.
Already, this test suite looks nicer. There is more to be done, however:
If/when this is merged, I will submit another PR consolidating common test code, and further modernizations including:
This PR contributes to #516 and #915