updating assembly versions, packageversions and publishing the packages#42823
updating assembly versions, packageversions and publishing the packages#42823Anipik merged 3 commits intodotnet:release/3.1from Anipik:packageUpdate
Conversation
safern
left a comment
There was a problem hiding this comment.
Could you also update System.Drawing.Common to contain 4.6.2 to fix harvesting validation?
I did it in runtime in master, it needs to be done here as well: dotnet/runtime#1729
| "InboxOn": { | ||
| "netcoreapp3.0": "4.0.0.0", | ||
| "netcoreapp3.1": "4.0.1.0", | ||
| "netcoreapp3.1": "4.0.1.1", |
There was a problem hiding this comment.
For future reference, this change was technically wrong as this assembly is also shipping out of an OOB package. When that is the case, you want to keep the InboxOn version frozen to the version you first shipped it on that framework, that way, if you ever service any package from this branch that takes a dependency on this library, our packaging infrastructure will force adding a package reference to the serviced version of this package.
There was a problem hiding this comment.
In all cases InboxOn should be frozen. Once an assembly is inbox in a framework that's defined the minimum version provided by the framework. Since a framework is targeted with a single thing: the TFM, we cannot depend on anything but the minimum version.
We have serviced 6 commits in 3.1.2
3 -> system.data.sqlclient
1 -> system.text.json
1 -> Reflection.MetadataLoadContext (eric already made that change for this change)
1 -> changes system.Native (part of shared framework)