Skip to content

Update System.Drawing.Common index to get latest package for harvesting#1729

Merged
safern merged 1 commit intodotnet:masterfrom
safern:UpdateSystemDrawingIndex
Jan 14, 2020
Merged

Update System.Drawing.Common index to get latest package for harvesting#1729
safern merged 1 commit intodotnet:masterfrom
safern:UpdateSystemDrawingIndex

Conversation

@safern
Copy link
Member

@safern safern commented Jan 14, 2020

All configurations libraries build is failing with error:

F:\workspace\_work\1\s\src\libraries\pkg\test\testPackages.proj(215,5): error : Validation Failed: System.Drawing.Common is harvesting assets from package version 4.6.1 which is not the latest for that package release. Latest package version from that release is 4.6.2. In order to fix this, run `dotnet msbuild System.Drawing.Common.pkgproj /t:UpdatePackageIndex /p:UpdateStablePackageInfo=true`

This fixes that issue by updating the package index to list the latest stable drawing packages.

joperezr
joperezr approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for fixing. As an FYI we should think about porting this change to release branches as it may be pertinent in those too.

@safern
Copy link
Member Author

safern commented Jan 14, 2020

As an FYI we should think about porting this change to release branches as it may be pertinent in those too.

That's right. I'll open a PR to those. In release/2.1 we don't harvest any assets for System.Drawing.Common so I think it would only make sense for release/3.0 and release/3.1

@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 14, 2020

Thanks, what about the error when executing the task in the error message that you mentioned in the standup?

@safern
Copy link
Member Author

safern commented Jan 14, 2020

Thanks, what about the error when executing the task in the error message that you mentioned in the standup?

I was missing to build the package itself. @joperezr is going to put up a fix to add a new target that hooks up build as a first step to update harvesting.

@safern
Copy link
Member Author

safern commented Jan 14, 2020

Libraries all configuration leg is green. Will merge to unblock other PRs.

@safern safern merged commit a4c0953 into dotnet:master Jan 14, 2020
@safern safern deleted the UpdateSystemDrawingIndex branch January 14, 2020 23:07
@safern safern mentioned this pull request Jan 14, 2020
Merged
@GrabYourPitchforks GrabYourPitchforks mentioned this pull request Jan 14, 2020
Merged
@joperezr joperezr mentioned this pull request Jan 15, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@joperezr joperezr joperezr approved these changes

Assignees

No one assigned

Labels

area-System.Drawing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@safern @ViktorHofer @joperezr @Dotnet-GitSync-Bot