This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Avoid ToCharArray allocation in JsonCamelCaseNamingPolicy#41363
Merged
stephentoub merged 1 commit intodotnet:masterfrom Sep 26, 2019
Merged
Avoid ToCharArray allocation in JsonCamelCaseNamingPolicy#41363stephentoub merged 1 commit intodotnet:masterfrom
stephentoub merged 1 commit intodotnet:masterfrom
Conversation
ahsonkhan
reviewed
Sep 26, 2019
| FixCasing(chars); | ||
| }); | ||
| #else | ||
| char[] chars = name.ToCharArray(); |
There was a problem hiding this comment.
Given property/key names are almost always small, is it worth it to copy the contents into a stackalloc span instead of always calling ToCharArray for say < 256?
Member
Author
There was a problem hiding this comment.
Maybe? Feel free to look at that separately; I'm going to skip it for this PR. I'm also not sure how much time we want to invest in the OOBs.
ahsonkhan
approved these changes
Sep 26, 2019
|
Candidate to port to 3.1 as part of the perf push. |
steveharter
added a commit
to steveharter/dotnet_corefx
that referenced
this pull request
Oct 14, 2019
steveharter
added a commit
to steveharter/dotnet_corefx
that referenced
this pull request
Oct 14, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microbenchmark calling ConvertName with either "PascalCase" or "camelCased":
cc: @steveharter, @ahsonkhan