This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add more Unicode validation tests#41265
Merged
stephentoub merged 2 commits intodotnet:masterfrom Sep 24, 2019
Merged
Conversation
Member
Author
|
/azp run corefx-outerloop-windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tarekgh
approved these changes
Sep 23, 2019
Member
tarekgh
left a comment
There was a problem hiding this comment.
Thanks for adding these tests. It is really useful.
stephentoub
reviewed
Sep 24, 2019
stephentoub
reviewed
Sep 24, 2019
src/System.Runtime/tests/System/Text/Unicode/UnicodeData.netcoreapp.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 24, 2019
src/System.Runtime/tests/System/Text/Unicode/UnicodeData.netcoreapp.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 24, 2019
| } | ||
| } | ||
|
|
||
| [OuterLoop] |
Member
There was a problem hiding this comment.
I assume you made all of these outerloop because they otherwise take too long to run in innerloop?
Member
Author
There was a problem hiding this comment.
They don't actually take all that long - less than 500ms on my machine combined. But if we follow this pattern of "test every possible input against known good output data", I can easily see these tests cumulatively going into the several-seconds range.
stephentoub
approved these changes
Sep 24, 2019
gfoidl
reviewed
Sep 24, 2019
Member
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Add more Unicode validation tests * PR feedback and add more char tests Commit migrated from dotnet/corefx@b59265f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some outerloop unit tests that parse the raw Unicode data files, then call various APIs on
charandRunepassing every possible input. The control results (as parsed from the raw data files) are compared against the runtime's output for correctness.This is largely in preparation for updating the runtime's stored Unicode table to version 12.1 (it's currently 11.0), including bringing forward invariant case mapping information.
There are no functional runtime changes in this PR.