This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Remove DEBUG-only TraceSource/Switch usage from corefx#41177
Merged
safern merged 1 commit intodotnet:masterfrom Sep 18, 2019
Merged
Remove DEBUG-only TraceSource/Switch usage from corefx#41177safern merged 1 commit intodotnet:masterfrom
safern merged 1 commit intodotnet:masterfrom
Conversation
A lot of TraceSource/Switch usage in corefx exists only to enable some optional DEBUG-only tracing and asserts, which haven't been used in a very long time, but some of it is keeping these types from being trimmed in a default MVC app.
maryamariyan
approved these changes
Sep 18, 2019
divega
approved these changes
Sep 18, 2019
safern
approved these changes
Sep 18, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…#41177) A lot of TraceSource/Switch usage in corefx exists only to enable some optional DEBUG-only tracing and asserts, which haven't been used in a very long time, but some of it is keeping these types from being trimmed in a default MVC app. Commit migrated from dotnet/corefx@80adc8b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of TraceSource/Switch usage in corefx exists only to enable some optional DEBUG-only tracing and asserts, which haven't been used in a very long time (if ever in corefx), but some of it is keeping these types from being trimmed in a default MVC app (even if the call sites are conditional, many of the switches themselves are not).
cc: @krwq, @Anipik, @safern, @maryamariyan, @divega