This repository was archived by the owner on Jan 23, 2023. It is now read-only.
improve span.StartsWith(span) test coverage#41169
Merged
adamsitnik merged 1 commit intodotnet:masterfrom Sep 18, 2019
Merged
Conversation
adamsitnik
commented
Sep 18, 2019
| Assert.Equal( | ||
| firstSpan.ToString().StartsWith(secondSpan.ToString(), StringComparison.CurrentCulture), | ||
| firstSpan.Contains(secondSpan, StringComparison.CurrentCulture)); | ||
| firstSpan.ToString().StartsWith(secondSpan.ToString(), StringComparison.CurrentCultureIgnoreCase), |
Member
Author
There was a problem hiding this comment.
this was a copy-paste error (so far StringComparison.CurrentCulture was tested twice)
stephentoub
reviewed
Sep 18, 2019
| firstSpan.ToString().StartsWith(secondSpan.ToString(), StringComparison.CurrentCulture), | ||
| firstSpan.Contains(secondSpan, StringComparison.CurrentCulture)); | ||
| firstSpan.ToString().StartsWith(secondSpan.ToString(), StringComparison.CurrentCultureIgnoreCase), | ||
| firstSpan.Contains(secondSpan, StringComparison.CurrentCultureIgnoreCase)); |
Member
There was a problem hiding this comment.
As long as you're fixing this, can you instead make it something like:
Assert.All(
new[] { StringComparison.CurrentCulture, StringComparison.CurrentCultureIgnoreCase, StringComparison.InvariantCulture, StringComparison.InvariantCultureIgnoreCase },
comparison =>
{
Assert.Equal(
firstSpan.ToString().StartsWith(secondSpan.ToString(), comparison),
firstSpan.Contains(secondSpan, comparison));
});?
That reduces the amount of code here, makes it clearer what's being tested, and helps to avoid such copy/paste issues.
stephentoub
approved these changes
Sep 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just wanted to make sure that
span.StartsWith(span)has the same test coverage asstring.StartsWith(string)