This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Remove use of non-generic Queue/Stack in System.Private.Xml#41142
Merged
stephentoub merged 1 commit intodotnet:masterfrom Sep 17, 2019
Merged
Remove use of non-generic Queue/Stack in System.Private.Xml#41142stephentoub merged 1 commit intodotnet:masterfrom
stephentoub merged 1 commit intodotnet:masterfrom
Conversation
This is the only reason these types are brought into a trimmed default MVC app.
Member
|
Are there any other references to System.Collections.NonGeneric remaining in System.Private.Xml? |
jkotas
approved these changes
Sep 16, 2019
Member
Author
Unfortunately, yes. Several public types derive from CollectionBase. |
krwq
approved these changes
Sep 16, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…orefx#41142) This is the only reason these types are brought into a trimmed default MVC app. Commit migrated from dotnet/corefx@6347f35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the only reason these types are brought into a trimmed default MVC app.
cc: @krwq, @jkotas