This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Enable Regex compiler to be trimmed#41075
Merged
stephentoub merged 1 commit intodotnet:masterfrom Sep 13, 2019
Merged
Conversation
Today an app that just does:
```C#
Console.WriteLine(Regex.IsMatch("12345", "0*[1-9][0-9]*"));
```
and is trimmed will end up publishing a 105K System.Text.RegularExpression.dll, including the regex compiler for when the RegexOptions.Compiled is used. We can refactor the constructors such that the compiler only ends up getting rooted when one of the ctors that takes options is used. After this PR, if you don't pass RegexOptions, the 105K drops to 85K.
stephentoub
commented
Sep 12, 2019
src/System.Text.RegularExpressions/src/System/Text/RegularExpressions/Regex.cs
Show resolved
Hide resolved
ViktorHofer
approved these changes
Sep 12, 2019
Member
ViktorHofer
left a comment
There was a problem hiding this comment.
Thanks. I'm not concerned about the changed behavior in the deserialization path.
jkotas
approved these changes
Sep 12, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Today an app that just does:
```C#
Console.WriteLine(Regex.IsMatch("12345", "0*[1-9][0-9]*"));
```
and is trimmed will end up publishing a 105K System.Text.RegularExpression.dll, including the regex compiler for when the RegexOptions.Compiled is used. We can refactor the constructors such that the compiler only ends up getting rooted when one of the ctors that takes options is used. After this PR, if you don't pass RegexOptions, the 105K drops to 85K.
Commit migrated from dotnet/corefx@31a5bba
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today an app that just does:
and is trimmed will end up publishing a 105K System.Text.RegularExpression.dll, including the regex compiler for when the RegexOptions.Compiled is used. We can refactor the constructors such that the compiler only ends up getting rooted when one of the ctors that takes options is used. After this PR, if you don't pass RegexOptions, the 105K drops to 85K.
cc: @ViktorHofer, @jkotas (@danmosemsft, just an example of what we talked about today)