This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Support nullable values in dictionaries#40991
Merged
layomia merged 5 commits intodotnet:masterfrom Sep 17, 2019
Merged
Conversation
ahsonkhan
reviewed
Sep 11, 2019
src/System.Text.Json/src/System/Text/Json/Serialization/JsonPropertyInfoNullable.cs
Show resolved
Hide resolved
src/System.Text.Json/src/System/Text/Json/Serialization/JsonPropertyInfoNullable.cs
Outdated
Show resolved
Hide resolved
src/System.Text.Json/src/System/Text/Json/Serialization/JsonPropertyInfoNullable.cs
Outdated
Show resolved
Hide resolved
src/System.Text.Json/tests/Serialization/Value.ReadTests.GenericCollections.cs
Outdated
Show resolved
Hide resolved
ahsonkhan
reviewed
Sep 12, 2019
src/System.Text.Json/src/System/Text/Json/Serialization/JsonPropertyInfoNullable.cs
Outdated
Show resolved
Hide resolved
ahsonkhan
reviewed
Sep 12, 2019
src/System.Text.Json/src/System/Text/Json/Serialization/JsonPropertyInfoNullable.cs
Outdated
Show resolved
Hide resolved
ahsonkhan
reviewed
Sep 12, 2019
...System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Write.HandleDictionary.cs
Outdated
Show resolved
Hide resolved
ahsonkhan
reviewed
Sep 12, 2019
ahsonkhan
approved these changes
Sep 13, 2019
ahsonkhan
left a comment
There was a problem hiding this comment.
Other than the leftover feedback/questions, LGTM.
src/System.Text.Json/src/System/Text/Json/Serialization/JsonPropertyInfoCommon.cs
Show resolved
Hide resolved
src/System.Text.Json/src/System/Text/Json/Serialization/JsonPropertyInfoNullable.cs
Show resolved
Hide resolved
src/System.Text.Json/src/System/Text/Json/Serialization/JsonPropertyInfoNullable.cs
Outdated
Show resolved
Hide resolved
ahsonkhan
reviewed
Sep 17, 2019
...System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Write.HandleDictionary.cs
Show resolved
Hide resolved
ahsonkhan
approved these changes
Sep 17, 2019
layomia
added a commit
to layomia/corefx
that referenced
this pull request
Sep 19, 2019
* Support nullable values in dictionaries * Address review feedback * Address feedback * Defer dictionary key escaping to writer
layomia
added a commit
that referenced
this pull request
Sep 20, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Support nullable values in dictionaries * Address review feedback * Address feedback * Defer dictionary key escaping to writer Commit migrated from dotnet/corefx@a308e93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/corefx/issues/40936.